Skip to content

Use tmp for atomic_save temp file suffix #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jph00 merged 1 commit into from
Jun 16, 2026
Merged

Use tmp for atomic_save temp file suffix #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastcore/xtras.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ def atomic_save(fn, mode='wb', uid=-1, gid=-1, **kwargs):
from tempfile import NamedTemporaryFile as ntf
fn = Path(fn)
fn.parent.mkdir_perms(parents=True, exist_ok=True, uid=uid, gid=gid)
with ntf(mode=mode, dir=fn.parent, delete=False, suffix=fn.suffix, **kwargs) as f:
with ntf(mode=mode, dir=fn.parent, delete=False, suffix='tmp', **kwargs) as f:
try: yield f
except:
Path(f.name).unlink(missing_ok=True)
Expand Down
8 changes: 5 additions & 3 deletions nbs/03_xtras.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,13 +1377,14 @@
" from tempfile import NamedTemporaryFile as ntf\n",
" fn = Path(fn)\n",
" fn.parent.mkdir_perms(parents=True, exist_ok=True, uid=uid, gid=gid)\n",
" with ntf(mode=mode, dir=fn.parent, delete=False, suffix=fn.suffix, **kwargs) as f:\n",
" with ntf(mode=mode, dir=fn.parent, delete=False, suffix='tmp', **kwargs) as f:\n",
" try: yield f\n",
" except:\n",
" Path(f.name).unlink(missing_ok=True)\n",
" raise\n",
" if uid>-1 or gid>-1: os.chown(f.name, uid, gid)\n",
" Path(f.name).rename(fn)\n"
" Path(f.name).rename(fn)\n",
""
]
},
{
Expand Down Expand Up @@ -1732,7 +1733,8 @@
"#| export\n",
"def is_listy(x):\n",
" \"`isinstance(x, (tuple,list,L,slice,Generator,set,frozenset))`\"\n",
" return isinstance(x, (tuple,list,L,slice,Generator,set,frozenset))\n"
" return isinstance(x, (tuple,list,L,slice,Generator,set,frozenset))\n",
""
]
},
{
Expand Down
Loading