[fix][ethereum2][offchain] fix period-tail sync committee verification#75
Open
fengjy73 wants to merge 1 commit into
Open
[fix][ethereum2][offchain] fix period-tail sync committee verification#75fengjy73 wants to merge 1 commit into
fengjy73 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation treated
period * syncPeriodLengthas the last slot of the current sync committee period, but that slot is actually the first slot of the next period. The real period tail is(period + 1) * syncPeriodLength - 1.On minimal private networks this causes verification failures around
64n - 1slots, where HCDVS may verify a sync aggregate with the wrong committee or fork domain and reportsync committee signature is invalid.This PR also preserves the actual slot that produced the sync aggregate, so missed slots and period-boundary endorsements no longer rely on guessing
block slot + 1.signature_slotin consensus endorsements.lib/ptc/CommitteePtcVerifier.solfrom web3j wrapper generation.