refactor(config): use pydantic when loading config#3261
Merged
Conversation
olivierPigeon-RTE
changed the title
olivierPigeon-RTE
force-pushed
the
refactor/use-pydantic-when-loading-config
branch
from
5bc777a to
8760f25
Compare
olivierPigeon-RTE
force-pushed
the
refactor/use-pydantic-when-loading-config
branch
from
bbc7b5f to
be87c29
Compare
sylvlecl
previously approved these changes
Jun 29, 2026
| return OutOfStudyFileOutputStorageConfig(storage_dir=storage_dir) | ||
| @model_validator(mode="after") | ||
| def _create_storage_dir(self) -> "OutOfStudyFileOutputStorageConfig": | ||
| self.storage_dir.mkdir(parents=True, exist_ok=True) |
Member
There was a problem hiding this comment.
Should be created by the storage when it's created, not just when we read the config.
But not related to that PR
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.