(PR51) Documentation/Investment Tutorial#135
Conversation
aoustry
left a comment
There was a problem hiding this comment.
Good job, I think there is still some room of improvements to have something really nice!
Please think of adding e2e tests, as for the other tutorials.
| id: investment_library | ||
| description: "Library for the investment tutorial jupyter notebook" | ||
|
|
||
|
|
There was a problem hiding this comment.
Remove from the investment_tutorial_library the models that are not used in the system please.
| description: A port that transfers quantities of gas emissions. | ||
| fields: | ||
| - id: co2 | ||
|
|
There was a problem hiding this comment.
In this tutorial, it could be good to also invest on storage capacities. In the modelling, you can have a duration parameters that links the injection/withdrawal capacity with the reservoir capacity (ex: reservoir capacity = duration *injection_capacity; all capacities are variables)
There was a problem hiding this comment.
In the tutorial you can have first a case where you invest only on the generation unit, and then a second case where you invest on both -> normally, when you have the possibility to invest also on the battery, this should reduce the optimal investment in the generation capacity.
There was a problem hiding this comment.
Please add more timesteps : 24 for instance, for one days.
You can explain in the description of the tutorial that the MC scenarios are "representative days".
There was a problem hiding this comment.
Also the 24 hours timeseries should look somehow "realistic"
There was a problem hiding this comment.
I used the 7 days TS from the tutorial about unit commitment as a base for these TS
| "We use **3 scenarios** and **4 timesteps**:\n", | ||
| "\n", | ||
| "| Scenario | Load level | Renewable share | Without investment |\n", | ||
| "|---|---|---|---|\n", | ||
| "| **S1** — Favourable | Low (190–220 MW) | High (100–140 MW) | Adequate — no problem |\n", | ||
| "| **S2** — Critical | High (450–500 MW) | Low (20–40 MW) | ~220–275 MW unsupplied per timestep |\n", | ||
| "| **S3** — Intermediate | Medium (310–360 MW) | Medium (60–90 MW) | ~20–90 MW unsupplied per timestep |\n", | ||
| "\n", |
There was a problem hiding this comment.
As explained the scenarios should be at least days.
| "Load (demand in MW) : \n", | ||
| "| S1 | S2 | S3 |\n", | ||
| "| --- | --- | --- |\n", | ||
| "| 200 | 450 | 320 |\n", | ||
| "| 210 | 480 | 340 |\n", | ||
| "| 190 | 460 | 310 |\n", | ||
| "| 220 | 500 | 360 |\n", | ||
| "\n", | ||
| "Renewable production (in MW) :\n", | ||
| "| S1 | S2 | S3 |\n", | ||
| "| --- | --- | --- |\n", | ||
| "| 120 | 30 | 80 |\n", | ||
| "| 100 | 20 | 60 |\n", | ||
| "| 140 | 40 | 90 |\n", | ||
| "| 110 | 25 | 70 |\n", |
There was a problem hiding this comment.
You should present this in graphs
| "\n", | ||
| "The study folder is inside the [`Tutorial_3_Investment/`](../Tutorial_3_Investment/Tutorial_Investment/ -TODO link to zip folder)\n", | ||
| "\n", | ||
| "The `basic-models-library` was used as a basis for creating the `investment_library.yml` where the new model **candidate_generator** was added.\n", |
There was a problem hiding this comment.
This sentence should be removed: it is not useful to explain how you generate this lib. you just mention here what is the library you're using, and give a link to the yml file.
| }, | ||
| "metadata": { | ||
| "image/png": { | ||
| "alt": "Stacked bar charts showing dispatch (existing thermal, candidate thermal, renewable) for each of the 3 scenarios across 4 timesteps." |
There was a problem hiding this comment.
- please explain the investment results before explaining the dispatch results
- for the dispatch results, please production that looks like this : https://berthub.eu/articles/posts/dutch-electrical-power-figures-2/
There was a problem hiding this comment.
- explanations added
- plots changed for stack plots
| - id: investment_cost | ||
| time-dependent: false | ||
| scenario-dependent: false | ||
| value: 50 # €/MW |
There was a problem hiding this comment.
The investment costs are derived from the annual payments, converted to a daily basis (given that the time horizon for the problems is one day); I propose using €250/MW.day (this corresponds to € 91,250/MW.year)
So use the numerical value 250 and give my explanations in #comments.
…input/model-libraries/investment_library.yml Co-authored-by: Antoine Oustry, PhD <58943406+aoustry@users.noreply.github.com>
Process ID
Process:
DOC-02
Description
Handle the issue #143
Need to add e2e tests following #126
Impact Analysis
yes, it adds e2e tests
Checklist
library.versioninlibraries/<library>.yml)libraries/CHANGELOG-<library>.md)doc/0_Home/4_release_notes.md)COMPATIBILITY.md)AGENTS.mdreviewed for impact and updated if needed