Extra checks

Author: AntoinePrv

cpp/src/arrow/util/bpacking_dispatch_internal.h

@@ -98,6 +98,8 @@ using SpreadBufferUint = std::conditional_t<
 /// stop if it finds a byte aligned value start.
 template <int kPackedBitWidth, bool kIsProlog, typename Uint>
 int unpack_exact(const uint8_t* in, Uint* out, int batch_size, int bit_offset) {
+  static_assert(kPackedBitWidth > 0);
+
   // For the epilog we adapt the max spread since better alignment give shorter spreads
   ARROW_DCHECK(kIsProlog || bit_offset == 0);
   ARROW_DCHECK(bit_offset >= 0 && bit_offset < 8);
@@ -121,6 +123,7 @@ int unpack_exact(const uint8_t* in, Uint* out, int batch_size, int bit_offset) {
   while ((start_bit < start_bit_term) && (!kIsProlog || (start_bit % 8 != 0))) {
     const int start_byte = start_bit / 8;
     const int spread_bytes = ((start_bit + kPackedBitWidth - 1) / 8) - start_byte + 1;
+    ARROW_DCHECK_LE(spread_bytes, kMaxSpreadBytes);
     ARROW_COMPILER_ASSUME(spread_bytes <= kMaxSpreadBytes);
 
     // Reading the bytes for the current value.

cpp/src/arrow/util/rle_encoding_internal.h

@@ -159,10 +159,11 @@ class BitPackedRun {
   constexpr BitPackedRun(const uint8_t* data, rle_size_t values_count,
                          rle_size_t value_bit_width, rle_size_t max_read_bytes) noexcept
       : data_(data), values_count_(values_count), max_read_bytes_(max_read_bytes) {
-    ARROW_CHECK_GE(value_bit_width, 0);
-    ARROW_CHECK_GE(values_count_, 0);
-    ARROW_CHECK(max_read_bytes < 0 ||
-                bit_util::BytesForBits(value_bit_width * values_count) <= max_read_bytes);
+    ARROW_DCHECK_GE(value_bit_width, 0);
+    ARROW_DCHECK_GE(values_count_, 0);
+    ARROW_DCHECK(max_read_bytes < 0 ||
+                 bit_util::BytesForBits(value_bit_width * values_count) <=
+                     max_read_bytes);
   }
 
   constexpr rle_size_t values_count() const noexcept { return values_count_; }
@@ -172,7 +173,7 @@ class BitPackedRun {
   constexpr rle_size_t raw_data_size(rle_size_t value_bit_width) const noexcept {
     auto out = bit_util::BytesForBits(static_cast<int64_t>(value_bit_width) *
                                       static_cast<int64_t>(values_count_));
-    ARROW_CHECK_LE(out, std::numeric_limits<rle_size_t>::max());
+    ARROW_DCHECK_LE(out, std::numeric_limits<rle_size_t>::max());
     return static_cast<rle_size_t>(out);
   }