Skip to content

Commit 922cd72

Browse files
Skip test_rigid_object.py when the ovphysx wheel is absent
The isaaclab_ov CI job's glob collects all ``test/`` files under ``source/isaaclab_ov*``, including the isaaclab_ovphysx tests. The other three ovphysx tests in this directory already guard their isaaclab_ovphysx imports with ``pytest.importorskip("ovphysx.types", reason="ovphysx wheel not installed")``; only ``test_rigid_object.py`` went straight to a top-level ``from isaaclab_ovphysx.assets import RigidObject``, which raised ``ModuleNotFoundError`` at collection time and failed the entire isaaclab_ov job in the CI image (where the ovphysx wheel is not installed). Add the same ``importorskip`` guard so the file is skipped cleanly in that environment, matching the established pattern.
1 parent 53cf7c1 commit 922cd72

1 file changed

Lines changed: 14 additions & 8 deletions

File tree

source/isaaclab_ovphysx/test/assets/test_rigid_object.py

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,20 @@
3131
import torch
3232
import warp as wp
3333
from flaky import flaky
34-
from isaaclab_ovphysx.assets import RigidObject
35-
from isaaclab_ovphysx.physics import OvPhysxCfg, OvPhysxManager
36-
37-
import isaaclab.sim as sim_utils
38-
from isaaclab.assets import RigidObjectCfg
39-
from isaaclab.sim import SimulationCfg, build_simulation_context
40-
from isaaclab.utils.assets import ISAAC_NUCLEUS_DIR, ISAACLAB_NUCLEUS_DIR
41-
from isaaclab.utils.math import (
34+
35+
# The CI isaaclab_ov* pattern unintentionally collects isaaclab_ovphysx tests,
36+
# but the ovphysx wheel is not installed in that environment. Skip gracefully
37+
# so the isaaclab_ov CI pipeline is not blocked by an unrelated dependency.
38+
pytest.importorskip("ovphysx.types", reason="ovphysx wheel not installed")
39+
40+
from isaaclab_ovphysx.assets import RigidObject # noqa: E402
41+
from isaaclab_ovphysx.physics import OvPhysxCfg, OvPhysxManager # noqa: E402
42+
43+
import isaaclab.sim as sim_utils # noqa: E402
44+
from isaaclab.assets import RigidObjectCfg # noqa: E402
45+
from isaaclab.sim import SimulationCfg, build_simulation_context # noqa: E402
46+
from isaaclab.utils.assets import ISAAC_NUCLEUS_DIR, ISAACLAB_NUCLEUS_DIR # noqa: E402
47+
from isaaclab.utils.math import ( # noqa: E402
4248
combine_frame_transforms,
4349
default_orientation,
4450
quat_apply_inverse,

0 commit comments

Comments
 (0)