Commit f495912
committed
Align OVPhysX ContactSensor parity with PhysX/Newton
Three small parity fixes that came out of a code review against the
PhysX/Newton implementations:
* Rename ``update_net_forces_kernel`` to
``update_net_forces_ovphysx_kernel``. PhysX ships a kernel of the same
name with a different signature (env-major vs sensor-major index
order); the explicit suffix prevents a confusing compile error if
someone cross-imports.
* ``ContactSensor.body_names`` now returns ``list[str]`` (never ``None``)
and raises a clear ``RuntimeError`` if accessed before initialization,
matching the PhysX contract.
* Add ``_set_debug_vis_impl`` and a no-op ``_debug_vis_callback`` to the
OVPhysX ContactSensor. The kitless OVPhysX flow has no Kit renderer,
so the implementations log a one-shot warning and otherwise no-op,
but the hooks are wired so ``cfg.debug_vis=True`` surfaces an
explicit message instead of silently doing nothing.1 parent 2578b48 commit f495912
2 files changed
Lines changed: 47 additions & 5 deletions
Lines changed: 46 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
31 | | - | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| 38 | + | |
| 39 | + | |
37 | 40 | | |
38 | 41 | | |
39 | 42 | | |
| |||
131 | 134 | | |
132 | 135 | | |
133 | 136 | | |
134 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
135 | 144 | | |
136 | | - | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
137 | 150 | | |
138 | 151 | | |
139 | 152 | | |
| |||
330 | 343 | | |
331 | 344 | | |
332 | 345 | | |
333 | | - | |
| 346 | + | |
334 | 347 | | |
335 | 348 | | |
336 | 349 | | |
| |||
453 | 466 | | |
454 | 467 | | |
455 | 468 | | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
456 | 498 | | |
457 | 499 | | |
458 | 500 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
190 | | - | |
| 190 | + | |
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
| |||
0 commit comments