Sync from local-mgr: maintainability framing, item-1-open, credit_service notes

README: existing-db-first quick start, "is this maintainable?" question framing
for section 1, business logic as 4th generated artifact, reworded iterate-step
rationale, merged AI-assistant-selection/paste-prompt summary line.

create_codespaces_mgr.py: item 1's details block now opens by default in
Codespaces (reviewer feedback - devs skim code, not prose; first code block
shouldn't need a click on a first-time visit). Fixed CS/browser-note injection
anchor, which had drifted onto a stale "See it work" match after local-mgr's
title rewrite -- re-anchored to the outer "<details>\n<summary>⚡ ..." summary,
distinct from the item-1-open patch's anchor.

credit_service.py: propagated bug/perf notes from local-mgr's basic_demo_logic_gov.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: valhuber

.devcontainer/create_codespaces_mgr.py

@@ -255,10 +255,11 @@ def main():
     readme = readme.lstrip("\n")
     print("  ✅ Front matter and style block stripped")
 
-    # Inject Codespaces + browser notes inside "See it work" (idempotent)
-    # Match on the stable "<summary>⚡ See it work" prefix — the text after the
-    # em-dash is gold-source copy (org_git/Docs) and changes independently of this script.
-    summary_re = re.compile(r"<summary>⚡ See it work[^<]*</summary>")
+    # Inject Codespaces + browser notes right after the outer "First Time Here?" details
+    # summary (idempotent). Match on the stable "<details>\n<summary>⚡ ...</summary>" prefix —
+    # the text after the lightning bolt is gold-source copy (org_git/Docs) and changes
+    # independently of this script.
+    summary_re = re.compile(r"<details>\n<summary>⚡[^<]*</summary>")
     if "Use Chrome or Edge" not in readme:
         cs_note = (
             "\n&nbsp;\n\n"
@@ -269,14 +270,32 @@ def main():
         match = summary_re.search(readme)
         if not match:
             raise SystemExit(
-                "ERROR: no '<summary>⚡ See it work...</summary>' line found in README.md — "
+                "ERROR: no '<details>\\n<summary>⚡ ...</summary>' line found in README.md — "
                 "update this script's summary_re pattern to match the current heading."
             )
         readme = readme[:match.end()] + cs_note + readme[match.end():]
         print("  ✅ Codespaces + browser notes injected")
     else:
         print("  (notes already present, skipped)")
 
+    # Codespaces-only: open item 1's details block by default — reviewer feedback that
+    # devs skim code, not prose, and the first prompt-as-code-block should be visible
+    # without a click on a first-time, one-shot visit. Local README keeps it collapsed
+    # (every-day use, would be noisy). Scoped to item 1 only — items 2-6 stay collapsed,
+    # preserving the agenda/outline feel of the numbered list.
+    item1_re = re.compile(r"<details markdown>\n<summary>[^<]*?1\.[^<]*</summary>")
+    readme, n = item1_re.subn(
+        lambda m: m.group(0).replace("<details markdown>", "<details markdown open>", 1),
+        readme,
+        count=1,
+    )
+    if n == 0:
+        raise SystemExit(
+            "ERROR: could not find item 1's <details markdown> block to open by default — "
+            "update this script's item1_re pattern to match the current heading."
+        )
+    print("  ✅ Item 1 details block set to open by default (Codespaces-only)")
+
     readme_path.write_text(readme)
 
     # .vscode/settings.json — global interpreter (Manager root)

README.md

@@ -10,10 +10,10 @@ This is the start page for the [GenAI-Logic Manager](https://apilogicserver.gith
 
  
 
-## 🤖 AI Assistance - Tell Your AI Assistant
+## 🤖 AI Assistance
 
 <details markdown>
-<summary>Selecting your AI assistant</summary>
+<summary>First select your AI assistant, then paste the prompt below</summary>
 
 &nbsp;
 
@@ -25,7 +25,7 @@ For more information, see [AI-Enabled Projects](https://apilogicserver.github.io
 
 </details>
 
-Then paste this to your AI assistant:
+&nbsp;
 
 ```
 Please load `.github/.copilot-instructions.md`.
@@ -37,21 +37,21 @@ Please load `.github/.copilot-instructions.md`.
 <!-- CODESPACES-INSERT-POINT: create_codespaces_mgr.py injects browser note here — do not rename this heading -->
 
 <details>
-<summary>⚡ See it work — build a complete system from a prompt, including logic</summary>
+<summary>⚡ Try Prompt → System -- then ask: is this maintainable?</summary>
 &nbsp;
 
 You're already running in GitHub Codespaces — a cloud VS Code environment in your browser. Nothing to install. (Use Chrome or Edge — Safari has known compatibility issues with VS Code in the browser.)
 
 
-&nbsp;
+<br>
 
-<details markdown>
-<summary>&emsp;&emsp;1. Create — database, API, Admin App and business logic from a prompt</summary>
+<details markdown open>
+<summary>&emsp;&emsp;1. Create — API, Admin App and business logic from a prompt - existing db</summary>
 
-<br>Say this to your AI assistant (allow 8-10 mins):
+<br>Say this to your AI assistant (allow 2-3 mins):
 
 ```
-Create basic_demo, with customers, orders, items and products.
+Create basic_demo from samples/dbs/basic_demo.sqlite (customers, orders, products).
 
 Include a notes field for orders.
 
@@ -66,13 +66,24 @@ Use case: App Integration
     1. Publish the Order to Kafka topic 'order_shipping' if the date_shipped is not None.
 ```
 
-> Note: the prompt above creates a new database. You *could* use an existing one instead — `create basic_demo from samples/dbs/basic_demo.sqlite` — replacing the first 2 lines above.
+<details markdown>
+<summary>Or, create with a new database</summary>
+
+<br>The prompt above starts from an *existing* database — the common real-world case (1t does not need to be sqlite).   You could create the same system with a *new* database, using a file-based prompt:
+
+```
+Create basic_demo from samples/prompts/genai_demo.prompt
+```
+</details>
+
+&nbsp;
 
 Most code generators produce code you then have to own. This one produces *models* — executable, maintainable:
 
 1. **Data model** — `database/models.py`
 2. **Full JSONAPI** — Swagger, pagination, optimistic locking (`api/expose_api_models.py` — 52 lines, zero per-table code)
 3. **Admin App** — `ui/admin/admin.yaml`
+4. **Business logic** — `logic/logic_discovery/place_order/check_credit.py`
 
 Each small, readable, yours. Plain Python — standard tooling applies.
 
@@ -164,7 +175,11 @@ Full writeup: [samples/basic_demo_logic_gov/logic/readme_logic](https://apilogic
 <details markdown>
 <summary>&emsp;&emsp;6. Iterate — ask for a new rule in plain English</summary>
 
-<br>Try: *"Customers should not be able to create new orders if they have unresolved past due letters."* — watch the AI add and explain the new rule.
+<br>Try:
+```
+Customers should not be able to create new orders if they have unresolved past due letters.
+```
+Since the engine resolves dependencies at load time, adding this rule doesn't touch the 5 you already have — no regeneration, no regression risk. An AI rewriting procedural code from scratch would have to re-touch all of it, with more surface area for a missed path and more tokens spent doing it.
 
 </details>
 

samples/basic_demo_logic_gov/logic/procedural/credit_service.py

@@ -10,6 +10,16 @@
 #
 # And there's a bug in here. Do you really want to go hunt it down?
 #
+# The bug: nothing here handles an Order moving to a different Customer, or an
+# OrderDetail moving to a different Order — both old and new parents need their
+# totals recalculated, and this code only ever touches the current row's parent.
+# This is the same re-parenting class of bug documented in
+# logic/procedural/declarative-vs-procedural-comparison.md.
+#
+# The performance issue: calculate_customer_balance() and calculate_order_amount_total()
+# re-query and recompute every unshipped order's total from its line items on every call —
+# an N+1 query pattern with no caching, even when nothing relevant has changed.
+#
 # Note: this is a pre-built reference copy, kept here for browsing. Generating
 # a project from the prompt yourself will produce an equivalent file, possibly
 # under a different project name.