fix(block): allow secondary consume goals

Author: ApocDev

app/e2e/mut/goal-rates.e2e.ts

@@ -0,0 +1,51 @@
+import { DatabaseSync } from "node:sqlite";
+import { expect, test } from "@playwright/test";
+import { activeProjectDbFile, expectUndoTop, goto, uniqueName } from "./helpers";
+
+test("a secondary goal accepts and persists a negative consume rate", async ({ page }) => {
+  // Block 38's shape: Tar remains the primary sink while Shale oil is added as
+  // another goal and changed from the default production rate to consumption.
+  const data = {
+    recipes: [],
+    goals: [
+      { name: "tar", rate: -9.575 },
+      { name: "scrude", rate: 1 },
+    ],
+  };
+  const db = new DatabaseSync(activeProjectDbFile());
+  let id: number;
+  try {
+    db.exec("PRAGMA busy_timeout = 5000");
+    const inserted = db
+      .prepare("INSERT INTO blocks (name, data) VALUES (?, ?)")
+      .run(uniqueName("Secondary sink"), JSON.stringify(data));
+    id = Number(inserted.lastInsertRowid);
+  } finally {
+    db.close();
+  }
+
+  await goto(page, `/block/${id}`);
+  await page.getByRole("button", { name: "1", exact: true }).click();
+  const input = page.locator("input:focus");
+  await input.fill("-2.5");
+  await input.press("Enter");
+
+  await expect(page.getByRole("button", { name: "-2.5", exact: true })).toBeVisible();
+  await expectUndoTop(page, /Set "Shale oil" rate/);
+
+  const addConsumer = page.getByRole("button", {
+    name: "add a recipe that consumes Shale oil",
+  });
+  await expect(addConsumer).toBeVisible();
+  await addConsumer.click();
+  await expect(page.getByRole("dialog", { name: "Recipes that consume Shale oil" })).toBeVisible();
+
+  const saved = new DatabaseSync(activeProjectDbFile(), { readOnly: true });
+  try {
+    const row = saved.prepare("SELECT data FROM blocks WHERE id = ?").get(id) as { data: string };
+    const parsed = JSON.parse(row.data) as { goals: { name: string; rate: number }[] };
+    expect(parsed.goals.find((goal) => goal.name === "scrude")?.rate).toBe(-2.5);
+  } finally {
+    saved.close();
+  }
+});

app/src/components/block/editable-rate.test.tsx

@@ -0,0 +1,32 @@
+// @vitest-environment jsdom
+import { cleanup, fireEvent, render } from "@testing-library/react";
+import { afterEach, describe, expect, it, vi } from "vite-plus/test";
+import { EditableRate } from "./editable-rate.tsx";
+
+afterEach(cleanup);
+
+describe("EditableRate", () => {
+  it("commits a negative rate for a consume goal", () => {
+    const onChange = vi.fn();
+    const { getByRole } = render(<EditableRate value={1} onChange={onChange} />);
+
+    fireEvent.click(getByRole("button", { name: "1" }));
+    const input = getByRole("textbox");
+    fireEvent.change(input, { target: { value: "-2.5" } });
+    fireEvent.keyDown(input, { key: "Enter" });
+
+    expect(onChange).toHaveBeenCalledWith(-2.5);
+  });
+
+  it("converts a negative display-window rate back to per-second", () => {
+    const onChange = vi.fn();
+    const { getByRole } = render(<EditableRate value={1} unit="min" onChange={onChange} />);
+
+    fireEvent.click(getByRole("button", { name: "60" }));
+    const input = getByRole("textbox");
+    fireEvent.change(input, { target: { value: "-150" } });
+    fireEvent.keyDown(input, { key: "Enter" });
+
+    expect(onChange).toHaveBeenCalledWith(-2.5);
+  });
+});

app/src/components/block/editable-rate.tsx

@@ -70,8 +70,7 @@ export function EditableRate({
   const commit = () => {
     const parsed = parseRateInput(draft, power);
     // a power-unit value is already per-second — the display window doesn't apply
-    if (parsed && parsed.value >= 0)
-      onChange(parsed.perSecond ? parsed.value : parsed.value / factor);
+    if (parsed) onChange(parsed.perSecond ? parsed.value : parsed.value / factor);
     setEditing(false);
   };
   return (

app/src/components/block/goal-card.tsx

@@ -59,6 +59,7 @@ export function GoalCard({
           {goals.map((goal, i) => {
             const g = goal.name;
             const isFirst = i === 0;
+            const consumes = goal.rate < 0;
             const kind = kindOf(g);
             const goalMissing = res?.missing?.goods.includes(g) ?? false;
             const incidentalRate =
@@ -67,14 +68,14 @@ export function GoalCard({
                     .filter((spoilage) => spoilage.result === g)
                     .reduce((sum, spoilage) => sum + spoilage.rate, 0) ?? 0)
                 : 0;
-            // declared but no recipe in the block makes it — fixable, not broken.
+            // declared but no recipe in the block makes/consumes it — fixable, not broken.
             // Suppressed on a broken block: the missing-refs banner already
             // explains why nothing's being made there.
             const goalUnmade = !goalMissing && !res?.broken && (res?.unmade?.includes(g) ?? false);
             const extraText = goalMissing ? (
               "No longer exists in the current data."
             ) : goalUnmade ? (
-              "No recipe in this block makes it. Click to add one."
+              `No recipe in this block ${consumes ? "consumes" : "makes"} it. Click to add one.`
             ) : (
               <div className="space-y-1">
                 <div>
@@ -129,8 +130,8 @@ export function GoalCard({
                   </button>
                 </div>
                 <button
-                  onClick={() => (isFirst && goal.rate < 0 ? onUseFor(g) : onMakeFor(g))}
-                  aria-label={`add a recipe that makes ${res?.display?.[g] ?? g}`}
+                  onClick={() => (consumes ? onUseFor(g) : onMakeFor(g))}
+                  aria-label={`add a recipe that ${consumes ? "consumes" : "makes"} ${res?.display?.[g] ?? g}`}
                 >
                   <Icon kind={kind} name={g} size="lg" extraText={extraText} />
                 </button>

docs/guide/blocks.md

@@ -20,6 +20,8 @@ Select **New block**, then use **+ goal** to choose an item or fluid.
 
 - The first goal starts at `1/s`, names the block, and becomes its scaling anchor.
 - Select a displayed rate to edit it. Select its unit to work in `/s`, `/min`, or `/h`.
+- Enter a negative rate when the block should consume that item or fluid rather than produce
+  it. For example, `-10/min` makes the block consume at least 10 per minute.
 - Add more goals when the same production unit must guarantee several outputs.
 - Right-click a non-primary goal and select **Move to front (names the block)** to make it
   the primary goal.
@@ -30,7 +32,8 @@ production appears separately in Factory.
 
 ## Add recipes
 
-Select a goal icon to open **Recipes that make _goal_**. Within a recipe row:
+Select a positive goal icon to open **Recipes that make _goal_**. A negative consume goal
+instead opens **Recipes that consume _goal_**. Within a recipe row:
 
 - Select an ingredient chip to find recipes that make that ingredient.
 - Select a product chip to find recipes that consume that product.
@@ -69,6 +72,10 @@ The **Block balance** card summarizes:
 - goods entering as imports;
 - goods leaving as goals, surplus, or byproducts.
 
+Select an exported good to add a recipe that consumes its surplus inside the block. The
+selected consumer runs as part of the chain, including when one of its products feeds back
+into the block's consume goal.
+
 The recipe table explains how that result was produced. **Table** is the editing view;
 **Flow** is a read-only diagram of the same solved recipes and goods.