Skip to content

Darkpack Pull 5/1/2026#48

Merged
FalloutFalcon merged 61 commits into
ApocryphaXIII:masterfrom
FalloutFalcon:darkpack-pull-5-1-26
May 1, 2026
Merged

Darkpack Pull 5/1/2026#48
FalloutFalcon merged 61 commits into
ApocryphaXIII:masterfrom
FalloutFalcon:darkpack-pull-5-1-26

Conversation

@FalloutFalcon

Copy link
Copy Markdown
Member

No description provided.

Icarus-The-Sun and others added 30 commits April 25, 2026 09:44
## About The Pull Request
Adds canes to the pharmacy. 50 seemed like a fair price for them, but I
can change that if needed.
<details><summary>Screenshots</summary>
<p>
<img width="524" height="792" alt="Screenshot 2026-04-24 021355"
src="https://github.com/user-attachments/assets/fe7f542a-28bd-4140-9948-55f3bfd56fa5"
/>
</p>
</details> 

## Why It's Good For The Game
Gives players a way to obtain canes besides crafting them from wood.
## Changelog
:cl:
qol: Adds canes to the pharmacy
/:cl:
## About The Pull Request
Minor atomization of DarkPack13#683 and an alternative to a change made in DarkPack13#946
## Why It's Good For The Game
We want our hud to update when we frenzy, or our splat changes
## Changelog
:cl:
fix: Changing splats will properly update your emotion aura
/:cl:
## About The Pull Request
Upstreaming of
The-Final-Nights/The-Final-Nights-Rebase#229
## Why It's Good For The Game
## Changelog
:cl:
fix: fixed an issue where disciplines would appear on the wrong
characters in some instances
/:cl:

Co-authored-by: buffyuwu <42501819+buffyuwu@users.noreply.github.com>
## About The Pull Request
Changes Night Vision to True Night Vision from Pierce the Veil.
<details><summary>Screenshots</summary>
<p>
True Night Vision
<img width="404" height="298" alt="Screenshot 2026-04-24 234515"
src="https://github.com/user-attachments/assets/7d4a8f17-95f1-43ce-8c0e-74b2f8df8097"
/>
Normal Night Vision
<img width="445" height="509" alt="Screenshot 2026-04-25 000534"
src="https://github.com/user-attachments/assets/970eca4b-4ea8-478d-96cb-faff892a6a9c"
/>
</p>
</details> 

## Why It's Good For The Game
True night vision fits with how protean already does it, while basic
night vision might be a little too weak.

## Changelog
:cl:
balance: Changes night vision granted by the pierce the veil ritual to
be stronger
/:cl:
## About The Pull Request
reworks the code so its acctually possible to do job restrictions that
arent for vampires.

<img width="352" height="211" alt="image"
src="https://github.com/user-attachments/assets/1f29dbda-963e-43ce-89ab-0f66f48c570c"
/>

## Why It's Good For The Game
Someone reminded me it was missing.
Parody with vamp code
## Changelog
:cl:
balance: Some jobs are restricted by auspice or tribe
/:cl:
## About The Pull Request

melbert pr introduced heights into dna and it excluded two of our height
defines making those heights broken

## Why It's Good For The Game

height fix

## Changelog

:cl:

fix: fixes the very smallest and the very tallest height from not being
applied

/:cl:
## About The Pull Request

negative st_add_stat_mods do not work

## Why It's Good For The Game

negative st_add_stat_mods now work

## Changelog



:cl:

fix: negative stat modifiers now work

/:cl:
## About The Pull Request

adds an area check before continuing the crime report proc

## Why It's Good For The Game

because when i crinos on a lick in the sewers and kill 10 hobos
(servants of the wyrm) in the way i shouldnt have to deal with mortal
cops

## Changelog
:cl:
fix: Crime will no longer be automatically reported outside of
masquerade enforced areas
/:cl:

---------

Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
## About The Pull Request

Removes Dice output preference in favor of just always outputting to
chat unless its marked spammy per roll
## Why It's Good For The Game
This made alot more sense when they were more equivlent, pretty much
just showing the success.
The chat output has slowly outpaced balloon alert in terms of
information (now including stuff like the bumper text and feedback on
what dice were used). This is now a noob trab which just causes alot of
confusion because they dont know what the roll is acctually for, and
there was a point in time where it was the default which creates issue
for people who dont know its a setting.
## Changelog
:cl:
del: Removes dice output preference in favor of always outputting to
chat unless declared by the roll.
/:cl:
## About The Pull Request

was present in oldcode

should we even have these roles called 'la squadra' and 'la famiglia'
considering... they're a jojos bizarre adventure reference...?
<img width="672" height="555" alt="dreamseeker_PfXfYkGpDP"
src="https://github.com/user-attachments/assets/0c65bd0c-6d44-4331-b02e-9f102e5dbfb3"
/>


## Why It's Good For The Game

readding a feature

## Changelog
:cl:

fix: readds bank vault door to giovanni kindred roles

/:cl:

---------

Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
## About The Pull Request

makes store owners say funny and concerning and satirical things and
also revamps them giving them unique outfits
<img width="301" height="117" alt="dreamseeker_DrZPNAhhbO"
src="https://github.com/user-attachments/assets/d4066fef-ef5c-49a5-b665-e184385205d9"
/>

<img width="919" height="688" alt="dreamseeker_npq0THEXVN"
src="https://github.com/user-attachments/assets/5c930df4-9e82-4b40-ad2c-8217c9c0acec"
/>


## Why It's Good For The Game

immersion, flavor, humor

## Changelog

:cl:
add: store owners now say unique things to you when you open their store
add: store owners now have revamped outfits for unique and cool looks
/:cl:
## About The Pull Request

people said this wasnt working so i made it cooler

## Why It's Good For The Game

serpentis

## Changelog


:cl:
add: fixes serpentis 1
/:cl:

---------

Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
…rkPack13#973)

## About The Pull Request

makes lightposts go out when the area power transformer is broken

also wanna make them flicker

<img width="760" height="514" alt="dreamseeker_Bn0gwoRGdK"
src="https://github.com/user-attachments/assets/a66aebc9-8484-46bd-bd09-37f96e836b3f"
/>


## Why It's Good For The Game

this is cool

## Changelog
:cl:
add: makes lightposts go out when the area power transformer is broken

/:cl:

---------

Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
## About The Pull Request

I saw this in the files.
<img width="543" height="463" alt="image"
src="https://github.com/user-attachments/assets/175074cd-ad2d-4b9c-82e4-24fc74f0c0f5"
/>
## Why It's Good For The Game
onfloors good.
## Changelog
:cl:
image: hair dye spray has an onfloor
/:cl:
## About The Pull Request
a subtype for the street sign icon_state that displays the area its in.
<img width="1223" height="469" alt="image"
src="https://github.com/user-attachments/assets/7e82edfe-4128-4824-8c85-b56220cd6084"
/>

A subtype of for all the other street signs that we had in the dmi.


## Why It's Good For The Game
Where am I?
## Changelog
:cl:
qol: Street signs tell you where you are
/:cl:
theselfish and others added 16 commits April 30, 2026 18:53
## About The Pull Request
Adds the 'Permenant Third Eye' flaw from V20.

## Why It's Good For The Game

mor book stuff smiley face

## Changelog
:cl:
add: Tremere may have a Third Eye.
/:cl:

---------

Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request
Reworks frenzy to update it to modern code and features, and shift it
from an often frustrating experience to an actual TTRPG feature that
enhances role-play.

Current triggers are a few sources of flames for rotshrek, and the sight
and taste of blood. For vampires
For werewolf, the standard trigger of rage rolls doesn't actually exist
in many places right now so all there triggers would realistically be
social or alot more arbitrary RN. Considering making them roll on really
high hits of damage. Gonna tackle this in a separate PR as im happy with
the overall state for vampires specifically.

Once trigger, it causing a bunch of visual flair and draws an overlay on
the closets target or reason for frenzying (fire for rotshreck, a random
living target for rage/blood frenzies)
These overlays will persist intill either a full scene passes, or the
frenzied has no targets visible for a period of time

## Why It's Good For The Game
## Changelog
:cl:
add: reworks frenzying to be a role-play/fluff effect rather then
stealing control of your character.
fix: color effect from Kiss status effect should properly clear
/:cl:

---------

Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request
Adjusts alot of comments to match our readme.md found in our modular
folder.
## Why It's Good For The Game
Please follow our readme 😢

---------

Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request
I had held off doing this with the worry that AGG didnt damage basic
mobs. Checking the code, this is actually not true and Lucia is awesome
actually.
## Why It's Good For The Game
TTRPG accuracy and a buff they kinda need apparently.
## Changelog
:cl:
balance: Fera claws are sharp and deal aggravated damage
/:cl:
## About The Pull Request
Config for if role-play only quirks/merits are loaded and available.

Saw The-Final-Nights/The-Final-Nights-Rebase#245
and realized this should have existed for this exact purpose.

This does not include stuff that's hooks for roleplay but is still
clearly conveyed to other players (like permenent fangs) as you cant
just pretend they dont exist and can have real ramifications for some of
them.

## Why It's Good For The Game
Some servers dont want things that act as "freebie" points that you dont
"have" to roleplay in theory.
## Changelog
:cl:
config: Adds config for if roleplay only merits are available
/:cl:

---------

Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request
Upstreaming of
The-Final-Nights/The-Final-Nights-Rebase#208
with some bonus stack trace included
## Why It's Good For The Game
The old code was weirdly dense and buggy.
## Changelog
:cl: FalloutFalcon, CYBILIZE
fix: fixed separate phone calls occasionally sharing audio with each
other
code: corrected secure phone frequency assignment logic
/:cl:
## About The Pull Request
Primarly, dont kick someone if you have claws because it hurts your dps.
## Why It's Good For The Game
Someone being downed hurting your dps is counterintuitive.
## Changelog
:cl:
balance: Claws are prefered to kicking
fix: Claws get intended bonus dice on basic mobs
/:cl:
## About The Pull Request
Yea
## Why It's Good For The Game
Shooting forward like a torpedo from a prone position is silly
## Changelog
:cl:
balance: You can no longer jump while lying down
/:cl:
@FalloutFalcon FalloutFalcon merged commit 4e0a08c into ApocryphaXIII:master May 1, 2026
30 of 33 checks passed
@FalloutFalcon FalloutFalcon deleted the darkpack-pull-5-1-26 branch May 1, 2026 21:37
@FalloutFalcon FalloutFalcon added the Upstream Merge Copy and paste Darkpack code. If it compiles, it ships! label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants