More micro optimizations

Author: ApoloApps

compose/ui/ui-test/src/skikoMain/kotlin/androidx/compose/ui/test/InputDispatcher.skiko.kt

@@ -28,6 +28,7 @@ import androidx.compose.ui.input.pointer.PointerType
 import androidx.compose.ui.node.RootForTest
 import androidx.compose.ui.platform.PlatformRootForTest
 import androidx.compose.ui.scene.ComposeScenePointer
+import androidx.compose.ui.util.fastForEach
 
 @OptIn(InternalComposeUiApi::class)
 internal actual fun createInputDispatcher(
@@ -300,7 +301,7 @@ internal class SkikoInputDispatcher(
     override fun flush() {
         val copy = batchedEvents.toList()
         batchedEvents.clear()
-        for (event in copy) {
+        copy.fastForEach { event ->
             advanceClockTime(event.eventTime - currentClockTime)
             currentClockTime = event.eventTime
             event.action()

compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/WindowComposeSceneLayer.desktop.kt

@@ -29,9 +29,11 @@ import androidx.compose.ui.platform.PlatformWindowContext
 import androidx.compose.ui.scene.skia.SkiaLayerComponent
 import androidx.compose.ui.skiko.OverlayRenderDecorator
 import androidx.compose.ui.unit.Density
+import androidx.compose.ui.unit.IntRect
 import androidx.compose.ui.unit.LayoutDirection
 import androidx.compose.ui.unit.roundToIntRect
 import androidx.compose.ui.unit.toOffset
+import androidx.compose.ui.util.fastRoundToInt
 import androidx.compose.ui.window.density
 import androidx.compose.ui.window.getDialogScrimBlendMode
 import androidx.compose.ui.window.layoutDirectionFor
@@ -113,8 +115,12 @@ internal class WindowComposeSceneLayer(
     override var scrimColor: Color? = null
 
     init {
-        val boundsInPx = windowContainer.sizeInPx.toRect()
-        drawBounds = boundsInPx.roundToIntRect()
+        drawBounds =  IntRect(
+            0,
+            0,
+            windowContainer.sizeInPx.width.fastRoundToInt(),
+            windowContainer.sizeInPx.height.fastRoundToInt()
+        )
         mediator = ComposeSceneMediator(
             container = container,
             isWindowLevel = true,

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/RootNodeOwner.skiko.kt

@@ -358,10 +358,10 @@ internal class RootNodeOwner(
     }
 
     private fun isInBounds(localPosition: Offset): Boolean =
-        size?.toIntRect()?.toRect()?.contains(localPosition) ?: true
+        size?.toRect()?.contains(localPosition) ?: true
 
     private fun calculateBoundsInWindow(): Rect? {
-        val rect = size?.toIntRect()?.toRect() ?: return null
+        val rect = size?.toRect() ?: return null
         val p0 = platformContext.convertLocalToWindowPosition(Offset(rect.left, rect.top))
         val p1 = platformContext.convertLocalToWindowPosition(Offset(rect.left, rect.bottom))
         val p3 = platformContext.convertLocalToWindowPosition(Offset(rect.right, rect.top))
@@ -732,7 +732,7 @@ internal class RootNodeOwner(
         override val semanticsOwner get() = owner.semanticsOwner
         override val visibleBounds: Rect
             get() {
-                val windowRect = platformContext.windowInfo.containerSize.toIntRect().toRect()
+                val windowRect = platformContext.windowInfo.containerSize.toRect()
                 val ownerRect = calculateBoundsInWindow()
                 return ownerRect?.intersect(windowRect) ?: windowRect
             }

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/LegacyRenderNodeLayer.skiko.kt

@@ -49,6 +49,7 @@ import androidx.compose.ui.unit.Density
 import androidx.compose.ui.unit.IntOffset
 import androidx.compose.ui.unit.IntSize
 import androidx.compose.ui.unit.dp
+import androidx.compose.ui.unit.toRect
 import androidx.compose.ui.unit.toSize
 import kotlin.math.abs
 import kotlin.math.max
@@ -245,7 +246,7 @@ internal class LegacyRenderNodeLayer(
 
         if (picture == null) {
             val measureDrawBounds = !clip || shadowElevation > 0
-            val bounds = size.toSize().toRect()
+            val bounds = size.toRect()
             val pictureCanvas = pictureRecorder.beginRecording(
                 left = if (measureDrawBounds) PICTURE_MIN_VALUE else bounds.left,
                 top = if (measureDrawBounds) PICTURE_MIN_VALUE else bounds.top,

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/unit/Density.skiko.kt

@@ -79,3 +79,11 @@ internal inline fun Size.toDpSize(density: Density): DpSize = with(density) {
 internal inline fun DpSize.toSize(density: Density): Size = with(density) {
    toSize()
 }
+
+/**
+ * Converts a [IntSize] to a [Rect].
+ */
+@Stable
+internal inline fun IntSize.toRect(): Rect =
+    Rect(0f, 0f, width.toFloat(), height.toFloat())
+