feat: support i18n in the 'delete my account' operation #7635
Merged
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom Mar 31, 2025
Merged
feat: support i18n in the 'delete my account' operation #7635LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request introduces i18n support for the delete my account operation. It replaces the hardcoded confirmation text in the account deletion dialog with a translation key and provides translations for multiple languages. The confirmation text validation logic is also updated to accept the translated text. Sequence diagram for account deletion with i18nsequenceDiagram
participant User
participant AccountDeletionDialog
participant FlowyTextField
User->>AccountDeletionDialog: Opens account deletion dialog
AccountDeletionDialog->>FlowyTextField: Displays translated confirmation hint
User->>FlowyTextField: Enters confirmation text
AccountDeletionDialog->>AccountDeletionDialog: Validates confirmation text against translated value
alt Text is valid
AccountDeletionDialog->>AccountDeletionDialog: Initiates account deletion
else Text is invalid
AccountDeletionDialog->>User: Shows error message
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider generating the
_acceptableConfirmTextslist from the translations to avoid hardcoding the confirmation phrases.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
92cb2db to
2552139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Add internationalization (i18n) support for the account deletion confirmation text
New Features:
Enhancements:
Documentation: