fix: add autofillHints support to AFTextField#8594
Merged
LucasXu0 merged 4 commits intoAppFlowy-IO:mainfrom Mar 20, 2026
Merged
fix: add autofillHints support to AFTextField#8594LucasXu0 merged 4 commits intoAppFlowy-IO:mainfrom
LucasXu0 merged 4 commits intoAppFlowy-IO:mainfrom
Conversation
Contributor
Reviewer's GuideAdds autofillHints support to AFTextField and updates project versioning and minor style fixes across several Flutter files. Class diagram for updated AFTextField with autofillHints supportclassDiagram
class AFTextField {
+FocusNode? focusNode
+bool readOnly
+int? maxLength
+Iterable<String>? autofillHints
+AFTextFieldState createState()
}
class AFTextFieldState {
}
class _AFTextFieldState {
+bool isObscured
+Widget build(BuildContext context)
}
class TextFieldWidget {
+Iterable<String>? autofillHints
}
AFTextField --> AFTextFieldState : creates
_AFTextFieldState --|> AFTextFieldState
AFTextFieldState ..> TextFieldWidget : configures
_AFTextFieldState ..> TextFieldWidget : passes_autofillHints
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The new
html: anydependency inpubspec.yamlis very loosely constrained; consider pinning it to a tested version range to avoid unexpected breakages from upstream changes. - For
AFTextField.autofillHints, consider documenting or constraining the expected values (e.g., referencing Flutter'sAutofillHintsconstants) to avoid incorrect or ineffective hint strings being passed in.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `html: any` dependency in `pubspec.yaml` is very loosely constrained; consider pinning it to a tested version range to avoid unexpected breakages from upstream changes.
- For `AFTextField.autofillHints`, consider documenting or constraining the expected values (e.g., referencing Flutter's `AutofillHints` constants) to avoid incorrect or ineffective hint strings being passed in.
## Individual Comments
### Comment 1
<location path="frontend/appflowy_flutter/pubspec.yaml" line_range="154" />
<code_context>
analyzer: 6.11.0
+ html: any
dev_dependencies:
# Introduce talker to log the bloc events, and only log the events in the development mode
</code_context>
<issue_to_address>
**issue (bug_risk):** Using an unconstrained `any` version for `html` may introduce unstable or breaking upgrades.
Allowing `html: any` means pub can choose newer versions arbitrarily, which increases the risk of future breakages (including for transitive consumers).
Please pin or range-constrain this dependency instead, for example:
```yaml
html: ^0.15.0
```
or another minimum version you actually depend on, so upgrades happen explicitly and can be evaluated when you choose to update.
</issue_to_address>
### Comment 2
<location path="CHANGELOG.md" line_range="222" />
<code_context>
+#### Bug Fixes
+- Fixed potential login token expired issue
+- Fixed inability to create Vault workspace on self-hosted servers with commercial plans
+- Fixed switching page rapidly caused the page flash
+
+### Mobile
</code_context>
<issue_to_address>
**issue (typo):** Clarify the wording in this bug fix entry for correct grammar.
The line "Fixed switching page rapidly caused the page flash" is ungrammatical. Please rephrase, e.g. "Fixed an issue where switching pages rapidly caused the page to flash."
Suggested implementation:
```
- Fixed an issue where switching pages rapidly caused the page to flash
```
I don’t see the `### Mobile` section content in the provided snippet, but the ungrammatical line should be located under that section for version 0.10.1 (or nearby). Make sure the `SEARCH` text exactly matches the existing line (including spacing and hyphen formatting) under the Mobile section when applying this change.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| analyzer: 6.11.0 | ||
|
|
||
| html: any |
Contributor
There was a problem hiding this comment.
issue (bug_risk): Using an unconstrained any version for html may introduce unstable or breaking upgrades.
Allowing html: any means pub can choose newer versions arbitrarily, which increases the risk of future breakages (including for transitive consumers).
Please pin or range-constrain this dependency instead, for example:
html: ^0.15.0or another minimum version you actually depend on, so upgrades happen explicitly and can be evaluated when you choose to update.
| #### Bug Fixes | ||
| - Fixed potential login token expired issue | ||
| - Fixed inability to create Vault workspace on self-hosted servers with commercial plans | ||
| - Fixed switching page rapidly caused the page flash |
Contributor
There was a problem hiding this comment.
issue (typo): Clarify the wording in this bug fix entry for correct grammar.
The line "Fixed switching page rapidly caused the page flash" is ungrammatical. Please rephrase, e.g. "Fixed an issue where switching pages rapidly caused the page to flash."
Suggested implementation:
- Fixed an issue where switching pages rapidly caused the page to flash
I don’t see the ### Mobile section content in the provided snippet, but the ungrammatical line should be located under that section for version 0.10.1 (or nearby). Make sure the SEARCH text exactly matches the existing line (including spacing and hyphen formatting) under the Mobile section when applying this change.
alexrosepizant
pushed a commit
to alexrosepizant/AppFlowy
that referenced
this pull request
Apr 13, 2026
* chore: bump version to 0.11.4 and update changelog * feat: add autofillHints support to AFTextField * fix: remove autoFocus from font search input * chore: fix code formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
close #8589
PR Checklist