fix: improve layout of shortcut key bindings#8609
Open
aayush-p-singh wants to merge 1 commit intoAppFlowy-IO:mainfrom
Open
fix: improve layout of shortcut key bindings#8609aayush-p-singh wants to merge 1 commit intoAppFlowy-IO:mainfrom
aayush-p-singh wants to merge 1 commit intoAppFlowy-IO:mainfrom
Conversation
- Replaced Row with Wrap in key bindings layout - Added spacing between keys for better alignment - Fixes uneven spacing and empty layout issue Closes AppFlowy-IO#8222
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces the fixed Row-based layout for displaying shortcut key bindings with a flexible Wrap layout that adds spacing between keys and improves alignment, especially when keys wrap or space is constrained. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that
_renderKeybindingsno longer usesisHovering, consider removing the parameter (and updating call sites) to keep the API minimal and avoid confusion. - Using
WrapAlignment.endmay cause unexpected layouts in RTL locales; consider deriving alignment from the currentTextDirectionor using a more neutral alignment if end-alignment is not strictly required.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that `_renderKeybindings` no longer uses `isHovering`, consider removing the parameter (and updating call sites) to keep the API minimal and avoid confusion.
- Using `WrapAlignment.end` may cause unexpected layouts in RTL locales; consider deriving alignment from the current `TextDirection` or using a more neutral alignment if end-alignment is not strictly required.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8222
Feature Preview
PR Checklist
Summary by Sourcery
Bug Fixes: