Skip to content

prevent malicious javascript execution in url_launcher.dart #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mateea326 wants to merge 1 commit into from
+8 −0
Closed

prevent malicious javascript execution in url_launcher.dart #8612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ Future<bool> afLaunchUri(
);
}

// Security: Prevent execution of dangerous URI schemes (XSS)
final validSchemes = ['http', 'https', 'mailto', 'tel', 'sms'];
if (uri.scheme.isNotEmpty && !validSchemes.contains(uri.scheme.toLowerCase())) {
Log.error('Blocked attempt to launch unsafe URI scheme: ${uri.scheme}');
return false;
}


// on Linux or Android or Windows, add http scheme to the url if it is not present
if ((UniversalPlatform.isLinux ||
UniversalPlatform.isAndroid ||
Expand Down
Loading