-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[FR] add an @ all members for notifications #8660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leticia-003
wants to merge
1
commit into
AppFlowy-IO:main
Choose a base branch
from
leticia-003:@allmembers-notifications-#8652
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
...r/lib/plugins/document/presentation/editor_plugins/mention/mention_all_members_block.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import 'package:appflowy/generated/flowy_svgs.g.dart'; | ||
| import 'package:appflowy/plugins/document/presentation/editor_plugins/mention/mention_block.dart'; | ||
| import 'package:flowy_infra_ui/flowy_infra_ui.dart'; | ||
| import 'package:flutter/material.dart'; | ||
|
|
||
| class MentionAllMembersBlock extends StatelessWidget { | ||
| const MentionAllMembersBlock({ | ||
| super.key, | ||
| required this.mention, | ||
| this.textStyle, | ||
| }); | ||
|
|
||
| final Map<String, dynamic> mention; | ||
| final TextStyle? textStyle; | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| final label = mention[MentionBlockKeys.label] as String? ?? 'all'; | ||
| final effectiveStyle = textStyle?.copyWith( | ||
| leadingDistribution: TextLeadingDistribution.even, | ||
| ); | ||
|
|
||
| final iconSize = (textStyle?.fontSize ?? 14.0) / 14.0 * 16.0; | ||
|
|
||
| return Wrap( | ||
| crossAxisAlignment: WrapCrossAlignment.center, | ||
| children: [ | ||
| Text( | ||
| '@$label', | ||
| style: effectiveStyle, | ||
| strutStyle: effectiveStyle != null | ||
| ? StrutStyle.fromTextStyle(effectiveStyle) | ||
| : null, | ||
| ), | ||
| const HSpace(4), | ||
| FlowySvg( | ||
| FlowySvgs.settings_members_m, | ||
| size: Size.square(iconSize), | ||
| color: effectiveStyle?.color, | ||
| ), | ||
| ], | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 138 additions & 0 deletions
138
frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/all_members_notification.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| import 'package:appflowy/generated/flowy_svgs.g.dart'; | ||
| import 'package:appflowy/plugins/document/presentation/editor_plugins/mention/mention_block.dart'; | ||
| import 'package:appflowy/plugins/inline_actions/inline_actions_result.dart'; | ||
| import 'package:appflowy/plugins/inline_actions/service_handler.dart'; | ||
| import 'package:appflowy/user/application/user_service.dart'; | ||
| import 'package:appflowy/workspace/application/user/user_workspace_bloc.dart'; | ||
| import 'package:appflowy_backend/protobuf/flowy-user/protobuf.dart'; | ||
| import 'package:appflowy_editor/appflowy_editor.dart'; | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_bloc/flutter_bloc.dart'; | ||
|
|
||
| class AllMembersNotificationService extends InlineActionsDelegate { | ||
| AllMembersNotificationService(this.context); | ||
|
|
||
| final BuildContext context; | ||
|
|
||
| static const _keywords = ['all', 'everyone', 'members', 'notify']; | ||
|
|
||
| List<WorkspaceMemberPB>? _members; | ||
| String? _workspaceId; | ||
|
|
||
| @override | ||
| Future<InlineActionsResult> search([ | ||
| String? search, | ||
| ]) async { | ||
| final workspace = | ||
| context.read<UserWorkspaceBloc?>()?.state.currentWorkspace; | ||
| if (workspace == null || | ||
| workspace.workspaceType == WorkspaceTypePB.LocalW) { | ||
| return InlineActionsResult(title: 'Notifications', results: const []); | ||
| } | ||
|
|
||
| if (_workspaceId != workspace.workspaceId || _members == null) { | ||
| _workspaceId = workspace.workspaceId; | ||
| _members = await _fetchWorkspaceMembers(workspace.workspaceId); | ||
| } | ||
|
|
||
| final members = _members ?? const <WorkspaceMemberPB>[]; | ||
| if (members.isEmpty) { | ||
| return InlineActionsResult(title: 'Notifications', results: const []); | ||
| } | ||
|
|
||
| if (!_matchesSearch(search)) { | ||
| return InlineActionsResult(title: 'Notifications', results: const []); | ||
| } | ||
|
|
||
| return InlineActionsResult( | ||
| title: 'Notifications', | ||
| startsWithKeywords: _keywords, | ||
| results: [ | ||
| InlineActionsMenuItem( | ||
| label: '@all', | ||
| keywords: _keywords, | ||
| iconBuilder: (_) => const FlowySvg( | ||
| FlowySvgs.settings_members_m, | ||
| size: Size.square(16), | ||
| ), | ||
| onSelected: (context, editorState, menuService, replace) => | ||
| _insertMention( | ||
| editorState, | ||
| workspace.workspaceId, | ||
| members, | ||
| replace.$1, | ||
| replace.$2, | ||
| ), | ||
| ), | ||
| ], | ||
| ); | ||
| } | ||
|
|
||
| bool _matchesSearch(String? search) { | ||
| if (search == null || search.isEmpty) { | ||
| return true; | ||
| } | ||
|
|
||
| final normalized = search.toLowerCase(); | ||
| return _keywords.any((keyword) => keyword.contains(normalized)); | ||
| } | ||
|
|
||
| Future<List<WorkspaceMemberPB>> _fetchWorkspaceMembers( | ||
| String workspaceId, | ||
| ) async { | ||
| final userProfile = context.read<UserWorkspaceBloc?>()?.state.userProfile; | ||
| if (userProfile == null) { | ||
| return const []; | ||
| } | ||
|
|
||
| final result = await UserBackendService( | ||
| userId: userProfile.id, | ||
| ).getWorkspaceMembers(workspaceId); | ||
|
|
||
| return result.fold( | ||
| (success) => success.items, | ||
| (_) => const [], | ||
| ); | ||
| } | ||
|
|
||
| Future<void> _insertMention( | ||
| EditorState editorState, | ||
| String workspaceId, | ||
| List<WorkspaceMemberPB> members, | ||
| int start, | ||
| int end, | ||
| ) async { | ||
| final selection = editorState.selection; | ||
| if (selection == null || !selection.isCollapsed) { | ||
| return; | ||
| } | ||
|
|
||
| final node = editorState.getNodeAtPath(selection.end.path); | ||
| final delta = node?.delta; | ||
| if (node == null || delta == null) { | ||
| return; | ||
| } | ||
|
|
||
| final memberEmails = members | ||
| .map((member) => member.email) | ||
| .where((email) => email.isNotEmpty) | ||
| .toList(); | ||
| if (memberEmails.isEmpty) { | ||
| return; | ||
| } | ||
|
|
||
| final transaction = editorState.transaction | ||
| ..replaceText( | ||
| node, | ||
| start, | ||
| end, | ||
| MentionBlockKeys.mentionChar, | ||
| attributes: MentionBlockKeys.buildMentionAllMembersAttributes( | ||
| workspaceId: workspaceId, | ||
| memberEmails: memberEmails, | ||
| ), | ||
| ); | ||
|
|
||
| await editorState.apply(transaction); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Storing full member email lists in the mention attributes is potentially heavy and exposes sensitive data in the document model.
buildMentionAllMembersAttributesembeds the fullmemberEmailslist into the document state, so every snapshot/sync will include all workspace member emails. This:Consider storing only minimal identifiers (e.g.
workspaceIdplus a token ormemberCount) and resolving the actual member list server‑side in the notification flow instead of persisting raw emails in the document model.