Skip to content

fix: propagate heading correctly #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saif-ellafi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: propagate heading correctly #1189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/src/editor/block_component/heading_block_component/heading_command_shortcut.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ KeyEventResult _toggleAttribute(
node.type == HeadingBlockKeys.type &&
node.attributes[HeadingBlockKeys.level] == level;

final delta = (node.delta ?? Delta()).toJson();

editorState.formatNode(
selection,
(node) => node.copyWith(
Expand All @@ -86,7 +84,7 @@ KeyEventResult _toggleAttribute(
node.attributes[blockComponentBackgroundColor],
blockComponentTextDirection:
node.attributes[blockComponentTextDirection],
blockComponentDelta: delta,
blockComponentDelta: (node.delta ?? Delta()).toJson(),
},
),
);
Expand Down
26 changes: 26 additions & 0 deletions test/new/block_component/heading_block_component/heading_command_shortcut_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,31 @@ void main() async {
node = editorState.getNodeAtPath([0])!;
expect(node.type, ParagraphBlockKeys.type);
});

test('toggle H1 preserves each selected node text', () {
const firstText = 'First paragraph';
const secondText = 'Second paragraph';
final document = Document.blank()
..addParagraph(initialText: firstText)
..addParagraph(initialText: secondText);

final editorState = EditorState(document: document)
..selection = Selection(
start: Position(path: [0], offset: 0),
end: Position(path: [1], offset: secondText.length),
);

toggleH1.execute(editorState);

final firstNode = editorState.getNodeAtPath([0])!;
final secondNode = editorState.getNodeAtPath([1])!;

expect(firstNode.type, HeadingBlockKeys.type);
expect(secondNode.type, HeadingBlockKeys.type);
expect(firstNode.attributes[HeadingBlockKeys.level], 1);
expect(secondNode.attributes[HeadingBlockKeys.level], 1);
expect(firstNode.delta?.toPlainText(), firstText);
expect(secondNode.delta?.toPlainText(), secondText);
});
});
}
Loading