prevent malicious javascript execution in url_launcher_extension.dart#1193
Closed
mateea326 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Closed
prevent malicious javascript execution in url_launcher_extension.dart#1193mateea326 wants to merge 1 commit intoAppFlowy-IO:mainfrom
mateea326 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Conversation
|
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(core): prevent malicious javascript execution in url_launcher
Description
This PR addresses a Cross-Site Scripting (XSS) vulnerability. Previously,
safeLaunchUrlandafLaunchUrlpassed URIs directly to theurl_launcherplugin without scheme validation. On Flutter Web, this allows the execution ofjavascript:URIs.This change introduces a strict whitelist of safe URI schemes (
http,https,mailto,tel,sms) to block the execution of dangerous payloads.Changes
appflowy_flutter'surl_launcher.dartwrapper.appflowy-editor'surl_launcher_extension.dartwrapper.Testing
[XSS](javascript:alert("xss"))no longer executes on the Web platform.