Add align support on QuillDeltaEncoder convert, and Fix for Flutter 3.44#1205
Add align support on QuillDeltaEncoder convert, and Fix for Flutter 3.44#1205rodolfogoulart wants to merge 7 commits into
Conversation
Add handling for 'align' attributes and ensure alignment is applied to nodes. Improve multi-line op.text processing by committing intermediate paragraphs, preserving styles and alignment, and starting a new open node for the last segment. Introduce helpers (_isListItem, _tryInsertNestedListNode, _findNearestParentNode) to robustly insert nested list nodes using the nearest parent and clear nestedLists when leaving list items. Also includes small refactors and formatting cleanups for list/heading/quote node creation.
Implement the new onFocusReceived callback introduced in Flutter 3.44 by returning true in DeltaTextInputService. This satisfies the updated API and prevents missing override/compatibility issues when compiling against the newer Flutter release. Fix for AppFlowy-IO#1204 /AppData/Local/Pub/Cache/git/appflowy-editor-6fbe7ba442ad942d6f18884f0a0c8278c524fa05/lib/src/editor/editor_component/service/ime/delta_input_service.dart(7,7): error G76B49859: The non-abstract class 'DeltaTextInputService' is missing implementations for these members
Change DeltaTextInputService.onFocusReceived to return the service's 'attached' state instead of always true. Flutter 3.44 added this callback; using 'attached' prevents reporting focus when the input service isn't attached and avoids incorrect focus behavior.
This reverts commit 4120422.
…utter 3.44" This reverts commit f6dced9.
|
|
Implement the new onFocusReceived callback introduced in Flutter 3.44 by returning true in DeltaTextInputService. This satisfies the updated API and prevents missing override/compatibility issues when compiling against the newer Flutter release. Fix for AppFlowy-IO#1204 /AppData/Local/Pub/Cache/git/appflowy-editor-6fbe7ba442ad942d6f18884f0a0c8278c524fa05/lib/src/editor/editor_component/service/ime/delta_input_service.dart(7,7): error G76B49859: The non-abstract class 'DeltaTextInputService' is missing implementations for these members
rodolfogoulart
changed the title
|
Thanks for tackling this @rodolfogoulart. One catch: Opened #1208 with the fix applied to both classes, scoped to just the Flutter 3.44 compat change (no QuillDeltaEncoder bundling), in case it's easier for maintainers to take that path. Happy to close it if you'd prefer to extend this PR. |
|
Thank man. |
|
No need for a second PR — #1208 already includes the Two ways the maintainers could handle it:
Either works for me — happy to follow whichever path the maintainers prefer. |
3 participants
Add align support when convert from quill to appflowy document.
Improve multi-line op.text processing by committing intermediate paragraphs, preserving styles and alignment, and starting a new open node for the last segment.
Fix for Flutter 3.44 [Bug] Flutter 3.44 not supported #1204