fix: produce minimal diff when node ids are not stable#1210
Open
LucasXu0 wants to merge 2 commits into
Open
Conversation
diffNodes matched children purely by id, so when ids were reassigned positionally or regenerated (e.g. Node.fromJson always creates fresh ids) an unchanged node could be paired with a different new node, yielding a spurious update + insert instead of a single insert. Replace the id lookup with a minimal edit-distance alignment that pairs children only when they share an id (update) or have identical content (unchanged), preferring unchanged over update over replacement. The op emission and OT composition are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.