Skip to content

Commit a8f2591

Browse files
perf: fixed strictmode violations and improved performance (#83)
1 parent 347d08a commit a8f2591

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

app/src/main/kotlin/io/github/landwarderer/futon/scrobbling/ScrobblingModule.kt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@ import dagger.hilt.android.qualifiers.ApplicationContext
88
import dagger.hilt.components.SingletonComponent
99
import dagger.multibindings.ElementsIntoSet
1010
import okhttp3.OkHttpClient
11-
import io.github.landwarderer.futon.BuildConfig
1211
import io.github.landwarderer.futon.core.db.MangaDatabase
1312
import io.github.landwarderer.futon.core.network.BaseHttpClient
14-
import io.github.landwarderer.futon.core.network.CurlLoggingInterceptor
1513
import io.github.landwarderer.futon.scrobbling.anilist.data.AniListAuthenticator
1614
import io.github.landwarderer.futon.scrobbling.anilist.data.AniListInterceptor
1715
import io.github.landwarderer.futon.scrobbling.anilist.domain.AniListScrobbler
@@ -75,16 +73,14 @@ object ScrobblingModule {
7573
@Singleton
7674
fun provideKitsuRepository(
7775
@ApplicationContext context: Context,
76+
@BaseHttpClient baseHttpClient: OkHttpClient,
7877
@ScrobblerType(ScrobblerService.KITSU) storage: ScrobblerStorage,
7978
database: MangaDatabase,
8079
authenticator: KitsuAuthenticator,
8180
): KitsuRepository {
82-
val okHttp = OkHttpClient.Builder().apply {
81+
val okHttp = baseHttpClient.newBuilder().apply {
8382
authenticator(authenticator)
8483
addInterceptor(KitsuInterceptor(storage))
85-
if (BuildConfig.DEBUG) {
86-
addInterceptor(CurlLoggingInterceptor())
87-
}
8884
}.build()
8985
return KitsuRepository(context, okHttp, storage, database)
9086
}

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ android.enableJetifier=false
1515
android.nonTransitiveRClass=true
1616
android.useAndroidX=true
1717
kotlin.code.style=official
18-
org.gradle.jvmargs=-Xmx2192M -Dkotlin.daemon.jvm.options\="-Xmx2192M"
18+
org.gradle.jvmargs=-Xmx8192M -Dkotlin.daemon.jvm.options\="-Xmx8192M"
1919
android.enableR8.fullMode=true
2020
android.nonFinalResIds=false
2121
org.gradle.parallel=true

0 commit comments

Comments
 (0)