F-Droid can't build

[licaon-kter]

Brief summary

No APK for https://github.com/AppFuton/Futon/releases/tag/v9.7 ?

Steps to reproduce

No response

Futon version

9.7

Android version

.

Device

No response

Acknowledgements

• This is not a duplicate of an existing issue. Please look through the list of open issues before creating a new one.
• This is not an issue with a specific manga source. Otherwise, you have to proceed from parsers repository.

[LandWarderer2772]

sorry about that we had to fix some issues so deleted the apk

[licaon-kter]

META-INF/version-control-info.textproto
4c4
<   revision: "a5ce8162251ef7d825190602b75cfcd756708a9f"
---
>   revision: "6b98e251d93d7ad78f44678dd52e826a847f2f98"

Please build from the tagged commit for release

[IzzySoft]

Chiming in from IzzyOnDroid:

! repo/io.github.landwarderer.futon_90700.apk declares sensitive permission(s): android.permission.REQUEST_INSTALL_PACKAGES

I see you've added an self updater – that's against the inclusion policies at both, F-Droid and IzzyOnDroid. So we will reject that update (F-Droid most likely as well) until this is clarified. You neither mentioned this with the release notes, nor are there any per-release changelogs pointing it out (looking for the latter: please move that directory inside of en-US, or it won't be detected).

[LandWarderer2772]

@licaon-kter

META-INF/version-control-info.textproto
4c4
<   revision: "a5ce8162251ef7d825190602b75cfcd756708a9f"
---
>   revision: "6b98e251d93d7ad78f44678dd52e826a847f2f98"

Please build from the tagged commit for release

We did build from the tagged commit. The hash of the tag was updated to the newer commit so 6b98e251d93d7ad78f44678dd52e826a847f2f98 was the hash of the version with issues and the current 9.7 tag hash is a5ce8162251ef7d825190602b75cfcd756708a9f

the release apk did have the same hash as the tag

[LandWarderer2772]

@IzzySoft

I see you've added an self updater

the AppUpdateRepository only checks for updates and points users to the GitHub releases page. It existed since 9.6.14 which you did allow. (It did use to have a downloading feature but was removed before adding to izzyondroid)

android.permission.REQUEST_INSTALL_PACKAGES

The feature that uses this is the new Mihon Extension manager which allows downloading installing and uninstalling only from the keiyoushi repository.

We did mention the addition of said feature as well as the extension manager in the changelogs
https://github.com/AppFuton/Futon/blob/devel/metadata/changelogs/90700.txt#L4
https://github.com/AppFuton/Futon/blob/devel/metadata/changelogs/90700.txt#L8

[licaon-kter]

The hash of the tag was updated to the newer commit

ah, missed it, builds fine 🎉

[licaon-kter]

the AppUpdateRepository only checks for updates and points users to the GitHub releases page.

when are users asked to opt-in for this update? because we need it to be opt-in, not "on by default"

users need to know this comes from Github too

how do I trigger it?

[IzzySoft]

the AppUpdateRepository only checks for updates and points users to the GitHub releases page.

And for that it needs android.permission.REQUEST_INSTALL_PACKAGES now? Our scanner yelled:

! repo/io.github.landwarderer.futon_90700.apk declares sensitive permission(s): android.permission.REQUEST_INSTALL_PACKAGES

So updates are disabled at IzzyOnDroid for now, and this one was rejected.

[LandWarderer2772]

the AppUpdateRepository only checks for updates and points users to the GitHub releases page.

when are users asked to opt-in for this update? because we need it to be opt-in, not "on by default"

users need to know this comes from Github too

how do I trigger it?

its manual only. And to check for update you need to be on an old version 9.6.14 to be exact. and it will show you hav a new update available. It does warn users that checks performed will not be bypassed

[LandWarderer2772]

can only be triggered manually. so its a manual update check
kinda the remnants of an old auto update check and updater

[IzzySoft]

Ah, the disclaimer is there (that it bypasses security checks; maybe also include F-Droid there, they perform checks, too 😉). But as @licaon-kter wrote: the check itself must be opt-in. Makes no sense to nag the people that GITHUB has updates, when they expect them from F-Droid/IzzyOnDroid, where they might not yet have arrived (e.g. because of some checks hit something, holding an update back – as it's the case currently).

So, is the check itself happening automatically in background – or only when "pressing a button" that clearly states the check happens at Github, not at "the store" one might have installed from.

That said, ideally, you remove that entirely, to avoid conflicts. Or "move" it to some other build variant.

[LandWarderer2772]

maybe also include F-Droid there, they perform checks, too 😉).

Yeah i will, its because that was changed first when i added to izzyondroid and forgot to update it when it got accepted into fdroid 😭

So, is the check itself happening automatically in background – or only when "pressing a button" that clearly states the check happens at Github, not at "the store" one might have installed from.

Only when pressing a button called check for updates inside settings>about
And i mean it does state that you will be downloading from github sooo... :)