Skip to content

ci: Added support for macOS#143

Merged
saikrishna321 merged 8 commits intoAppiumTestDistribution:mainfrom
ferozk:main
Sep 24, 2025
Merged

ci: Added support for macOS#143
saikrishna321 merged 8 commits intoAppiumTestDistribution:mainfrom
ferozk:main

Conversation

@ferozk
Copy link
Copy Markdown
Contributor

@ferozk ferozk commented Sep 17, 2025

Added support for macOS using mac2driver

@ferozk
Copy link
Copy Markdown
Contributor Author

ferozk commented Sep 17, 2025

@saikrishna321 @sudharsan-selvaraj please help why the tests are getting failed.

@ferozk ferozk changed the title Added support for macOS feat: Added support for macOS Sep 17, 2025
Comment thread src/commands/element.ts Outdated
@ferozk ferozk force-pushed the main branch 3 times, most recently from e380546 to 62c0ac6 Compare September 18, 2025 08:01
@ferozk
Copy link
Copy Markdown
Contributor Author

ferozk commented Sep 18, 2025

Can any one help why following e2e tests are failing
✖ Descendant Test
✖ Ancestor Test

@ferozk ferozk force-pushed the main branch 4 times, most recently from 77e5390 to ca638e3 Compare September 18, 2025 11:09
Comment thread src/commands/element.ts
@ferozk
Copy link
Copy Markdown
Contributor Author

ferozk commented Sep 19, 2025

@sudharsan-selvaraj units tests are failing now which were working fine before, after implementing your suggested code

@sudharsan-selvaraj
Copy link
Copy Markdown
Member

@sudharsan-selvaraj units tests are failing now which were working fine before, after implementing your suggested code

@ferozk Unit test needs to be fixed based on the new logic. You need to update the below assertions to match the correct element payload based on newly implemented logic.

 expect(
            mockDriver.command.calledWith('/element', 'POST', {
               strategy: 'strategy',
               selector: 'selector',
               context: 'context',
            }),
         ).to.be.true;

Comment thread package.json
@saikrishna321
Copy link
Copy Markdown
Member

@ferozk please fix linting

@ferozk
Copy link
Copy Markdown
Contributor Author

ferozk commented Sep 23, 2025

@ferozk please fix linting

updated.

@saikrishna321
Copy link
Copy Markdown
Member

Thanks for the PR @ferozk

@saikrishna321 saikrishna321 changed the title feat: Added support for macOS ci: Added support for macOS Sep 24, 2025
@saikrishna321
Copy link
Copy Markdown
Member

@ferozk This PR merge will not release, since we also want to add macos driver test. Will do that in a new PR and then release

@saikrishna321 saikrishna321 merged commit 20e47ac into AppiumTestDistribution:main Sep 24, 2025
4 checks passed
@ferozk
Copy link
Copy Markdown
Contributor Author

ferozk commented Sep 24, 2025

@ferozk This PR merge will not release, since we also want to add macos driver test. Will do that in a new PR and then release

Sure, Thanks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants