Singleton protection improved once again

Author: RNEvok

.github/workflows/npmPublish.yml

@@ -7,7 +7,7 @@ on:
     paths-ignore:
       - '.github/workflows/*' # не запускать воркфлоу при обновлении самих воркфлоу
 env:
-  NPM_VERSION_MODIFIER: minor
+  NPM_VERSION_MODIFIER: patch
   NODE_VERSION: 18.11.0
 jobs:
   Prepare_and_publish:

Connector.ts

@@ -69,10 +69,6 @@ class Connector extends Singleton {
 
   public lastEvent: T.RemoteEvent | null = null;
 
-  constructor() {
-    super("Connector");
-  };
-
   public addEventListener(key: string, handler: (event: T.RemoteEvent) => any) {
     this._eventListenersTable[key] = handler;
   };

helpers/classes/Singleton.ts

@@ -3,13 +3,10 @@ import { ObjectT } from "../../types";
 export abstract class Singleton {
   private static _classHasInstanceTable: ObjectT<boolean> = {};
 
-  constructor(classId: string) {
-    if (classId.length < 1)
-      throw new Error("Non-empty classId required for Singleton class protection!");
-
-    if (Singleton._classHasInstanceTable[classId])
+  constructor() {
+    if (Singleton._classHasInstanceTable[this.constructor.name])
       throw new Error("Attempted to create second instance of a Singleton class!");
 
-    Singleton._classHasInstanceTable[classId] = true;
+    Singleton._classHasInstanceTable[this.constructor.name] = true;
   }
 };

services/idService.ts

@@ -8,10 +8,6 @@ class IdService extends Singleton {
   private _currentInterceptedTanStackQueryEventId = 0;
   private _currentInterceptedMobxEventId = 0;
 
-  constructor() {
-    super("IdService");
-  }
-
   public get currentInterceptedReduxActionId() {
     return `RA_${this._currentInterceptedReduxActionId++}`;
   }

services/remoteSettingsService.ts

@@ -22,10 +22,6 @@ class RemoteSettingsService extends Singleton {
     delete this._remoteSettingsListenersTable[key];
   };
 
-  constructor() {
-    super("RemoteSettingsService");
-  }
-
   public onGotNewRemoteSettings(r: RemoteSettings) {
     if (!this._isInit)
       return;