Skip to content

chore: Update directory watcher and tell ProGuard to leave it alone #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rover656 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Update directory watcher and tell ProGuard to leave it alone #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04f10a8
chore: Update directory watcher and tell ProGuard to leave it alone
Rover656 Apr 15, 2026
f28b1a2
chore: Specifically only keep the JNI package members untouched by Pr…
Rover656 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ neoforge_version_range=[26.1.2.10-beta,26.2-)
# Third party dependencies
#########################################################
snakeyaml_version=1.33
directory_watcher_version=0.17.1
directory_watcher_version=0.19.1
junit_version=5.13.4
flatbuffers_version=23.5.26
ffmpeg_version=6.0-1.5.9
Expand Down
5 changes: 5 additions & 0 deletions proguard.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,8 @@
-keepclassmembers class guideme.internal.hooks.mixins.* {
*;
}

@Technici4n Technici4n Apr 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that it's because jni has a direct reference? (That's why, right?)

@shartte shartte Apr 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep all? How much bigger does this make the resulting jar?

@Rover656 Rover656 Apr 28, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look at how much can be stripped before it breaks, and document it's presence :)

@Rover656 Rover656 Apr 28, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File size difference after changing to only preserving the JNI package (which still fixes the root issue)

Before: 5,192,460 bytes (5.2 MB on disk)
After: 5,195,286 bytes (5.2 MB on disk)

@Technici4n Technici4n Apr 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So only preserving the JNI package made the jar larger?

@Rover656 Rover656 Apr 29, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, before is a compilation of main. After is this branch after changes made. I neglected to compare before making this change

# Ensure all JNI classes for DirectoryWatcher are kept to ensure hot reload works on MacOS
-keep class guideme.internal.shaded.methvin.watchservice.jna.* {
*;
}
Loading