[codex] Guard engine config flag emission#62
Draft
xu16601526267 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
startup.accepted_config_keysto engine YAML so narrow wrapper servers can declare exactly which config keys may be emitted as CLI flags.port, preventing LLM-only flags such as--max-model-lenfrom being passed to image servers.Why
AIMA can merge LLM-oriented defaults, automatic fit adjustments, or user overrides into a single config map. That is fine for broad engines such as vLLM, but narrow FastAPI/image/audio wrappers can fail at startup when they receive unrelated LLM flags. This change makes the engine catalog the source of truth for which config keys are runtime CLI flags.
Validation
git diff --checkgo test ./internal/knowledge -run "TestBuildSyntheticImageModelDoesNotInjectLLMContext|TestGeneratePodFiltersUnsupportedConfigFlags|TestBuildSyntheticConfig_NoVRAMLeakForEnginesWithoutDeclaredKnob"go test ./internal/runtime -run "TestConfigToFlagsHonorsAcceptedConfigKeys|TestBuildRunArgs_FiltersUnsupportedConfigFlags|TestToResolvedConfigCarriesAcceptedConfigKeys"Full
go test ./internal/knowledge ./internal/runtime ./cmd/aimawas also attempted on Windows.internal/knowledgepassed;internal/runtimeandcmd/aimastill hit existing Windows-environment failures around POSIX path expectations, stale PID/port detection, and symlink privileges.