[codex] Split dry-run resolved and effective config#63
Open
xu16601526267 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Linux target validation passed on Validation run:
Remote logs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes deploy dry-run output distinguish catalog/user-resolved config from the final config that AIMA would actually deploy after
CheckFitresource adjustments.What changed
configas the effective deployment config for backward compatibilityresolved_configandresolved_provenancefor pre-CheckFit valueseffective_config,effective_provenance, and top-levelfit_adjustmentsWhy
When
CheckFitlowersgpu_memory_utilizationormem_fraction_staticbecause of live memory pressure, UI and agents previously saw only the adjustedconfig. That made users think the catalog default itself was wrong.Validation
go test ./cmd/aima -run TestResolveDeploymentKeepsResolvedAndEffectiveConfigSeparate -count=1git diff --check