[codex] Filter engine config flags by command context#64
Open
xu16601526267 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Linux target validation passed on Validation run:
Remote logs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents resolver-only or LLM-only config knobs from being emitted as CLI flags for service wrappers that do not support them.
What changed
Why
AIMA can resolve generic model config keys such as
max_model_len,gpu_memory_utilization, andmem_fraction_static, but image/audio/TTS/OCR service wrappers often do not expose those flags. Emitting them caused one-click deploy failures such asserver.py: error: unrecognized arguments: --max-model-len 8192.Validation
go test ./internal/knowledge -count=1go test ./internal/runtime -run TestConfigToFlags -count=1git diff --check