Skip to content

Commit be39f72

Browse files
committed
refactor: diaryId로 일기 조회 FeedDiaryResponseDto 사용
1 parent 0e38ea5 commit be39f72

4 files changed

Lines changed: 12 additions & 6 deletions

File tree

src/main/java/apptive/team5/diary/controller/DiaryController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,13 @@ public ResponseEntity<Page<UserDiaryResponseDto>> getUserDiaries(
7474
}
7575

7676
@GetMapping("/{diaryId}")
77-
public ResponseEntity<UserDiaryResponseDto> getDiary(
77+
public ResponseEntity<FeedDiaryResponseDto> getDiary(
7878
@PathVariable
7979
Long diaryId,
8080
@AuthenticationPrincipal
8181
Long userId
8282
) {
83-
UserDiaryResponseDto response = diaryService.getDiary(diaryId, userId);
83+
FeedDiaryResponseDto response = diaryService.getDiary(diaryId, userId);
8484
return ResponseEntity.status(HttpStatus.OK).body(response);
8585
}
8686

src/main/java/apptive/team5/diary/service/DiaryService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ public Page<UserDiaryResponseDto> getUserDiaries(Long targetUserId, Long current
8181
}
8282

8383
@Transactional(readOnly = true)
84-
public UserDiaryResponseDto getDiary(Long diaryId, Long currentUserId) {
84+
public FeedDiaryResponseDto getDiary(Long diaryId, Long currentUserId) {
8585
DiaryEntity foundDiary = diaryLowService.findDiaryById(diaryId);
86-
return getDiaryResponseDto(currentUserId, foundDiary, UserDiaryResponseDto::from);
86+
return getDiaryResponseDto(currentUserId, foundDiary, FeedDiaryResponseDto::from);
8787
}
8888

8989
@Transactional(readOnly = true)

src/test/java/apptive/team5/diary/controller/DiaryControllerTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,14 +216,17 @@ void getDiary() throws Exception {
216216
.getResponse()
217217
.getContentAsString(StandardCharsets.UTF_8);
218218

219-
UserDiaryResponseDto diaryResponse = objectMapper.readValue(response, UserDiaryResponseDto.class);
219+
FeedDiaryResponseDto diaryResponse = objectMapper.readValue(response, FeedDiaryResponseDto.class);
220220

221221
assertSoftly(softly -> {
222222
softly.assertThat(diaryResponse.diaryId()).isEqualTo(publicDiary.getId());
223223
softly.assertThat(diaryResponse.content()).isEqualTo(publicDiary.getContent());
224224
softly.assertThat(diaryResponse.isLiked()).isTrue();
225225
softly.assertThat(diaryResponse.isStored()).isTrue();
226226
softly.assertThat(diaryResponse.likeCount()).isEqualTo(2L);
227+
softly.assertThat(diaryResponse.userId()).isEqualTo(testUser.getId());
228+
softly.assertThat(diaryResponse.username()).isEqualTo(testUser.getUsername());
229+
softly.assertThat(diaryResponse.tag()).isEqualTo(testUser.getTag());
227230
});
228231
}
229232

src/test/java/apptive/team5/diary/service/DiaryServiceTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,13 +234,16 @@ void getDiary() {
234234
given(diaryStoreLowService.findStoredDiaryIdsByUser(viewer.getId(), List.of(publicDiary.getId())))
235235
.willReturn(Set.of(publicDiary.getId()));
236236

237-
UserDiaryResponseDto result = diaryService.getDiary(publicDiary.getId(), viewer.getId());
237+
FeedDiaryResponseDto result = diaryService.getDiary(publicDiary.getId(), viewer.getId());
238238

239239
assertThat(result.diaryId()).isEqualTo(publicDiary.getId());
240240
assertThat(result.content()).isEqualTo(publicDiary.getContent());
241241
assertThat(result.isLiked()).isTrue();
242242
assertThat(result.isStored()).isTrue();
243243
assertThat(result.likeCount()).isEqualTo(3L);
244+
assertThat(result.userId()).isEqualTo(owner.getId());
245+
assertThat(result.username()).isEqualTo(owner.getUsername());
246+
assertThat(result.tag()).isEqualTo(owner.getTag());
244247

245248
verify(diaryLowService).findDiaryById(publicDiary.getId());
246249
verify(diaryLikeLowService).findLikedDiaryIdsByUser(viewer.getId(), List.of(publicDiary.getId()));

0 commit comments

Comments
 (0)