Improve error message for non-descriptive test names

nyurik · web-flow · commit dc87b28bdb4d · 2026-02-05T22:57:11.000-05:00
diff --git a/src/tools/tidy/src/ui_tests.rs b/src/tools/tidy/src/ui_tests.rs
@@ -302,7 +302,7 @@ fn deny_new_nondescriptive_test_names(
             && !stripped_path.starts_with("ui/issues/")
         {
             check.error(format!(
-                "the name of the file `tests/{stripped_path}` is not descriptive, consider renaming to `{{reason}}-issue-{issue_n}.rs`",
+                "issue-number-only test names are not descriptive, consider renaming file `tests/{stripped_path}` to `{{reason}}-issue-{issue_n}.rs`",
                 issue_n = &test_name[1],
             ));
         }

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@ fn deny_new_nondescriptive_test_names(`
`302`	`302`	`&& !stripped_path.starts_with("ui/issues/")`
`303`	`303`	`{`
`304`	`304`	`check.error(format!(`
`305`		- "the name of the file `tests/{stripped_path}` is not descriptive, consider renaming to `{{reason}}-issue-{issue_n}.rs`",
	`305`	+ "issue-number-only test names are not descriptive, consider renaming file `tests/{stripped_path}` to `{{reason}}-issue-{issue_n}.rs`",
`306`	`306`	`issue_n = &test_name[1],`
`307`	`307`	`));`
`308`	`308`	`}`