feat(client): add HttpResponse.ReadAsStream method

Author: stainless-app[bot]

src/ArcadeDotnet/ArcadeClient.cs

@@ -41,13 +41,13 @@ public bool ResponseValidation
         init { this._options.ResponseValidation = value; }
     }
 
-    public int MaxRetries
+    public int? MaxRetries
     {
         get { return this._options.MaxRetries; }
         init { this._options.MaxRetries = value; }
     }
 
-    public TimeSpan Timeout
+    public TimeSpan? Timeout
     {
         get { return this._options.Timeout; }
         init { this._options.Timeout = value; }
@@ -106,7 +106,8 @@ public async Task<HttpResponse> Execute<T>(
     )
         where T : ParamsBase
     {
-        if (this.MaxRetries <= 0)
+        var maxRetries = this.MaxRetries ?? ClientOptions.DefaultMaxRetries;
+        if (maxRetries <= 0)
         {
             return await ExecuteOnce(request, cancellationToken).ConfigureAwait(false);
         }
@@ -121,13 +122,13 @@ public async Task<HttpResponse> Execute<T>(
             }
             catch (Exception e)
             {
-                if (++retries > this.MaxRetries || !ShouldRetry(e))
+                if (++retries > maxRetries || !ShouldRetry(e))
                 {
                     throw;
                 }
             }
 
-            if (response != null && (++retries > this.MaxRetries || !ShouldRetry(response)))
+            if (response != null && (++retries > maxRetries || !ShouldRetry(response)))
             {
                 if (response.Message.IsSuccessStatusCode)
                 {
@@ -171,7 +172,9 @@ async Task<HttpResponse> ExecuteOnce<T>(
             Content = request.Params.BodyContent(),
         };
         request.Params.AddHeadersToRequest(requestMessage, this._options);
-        using CancellationTokenSource timeoutCts = new(this.Timeout);
+        using CancellationTokenSource timeoutCts = new(
+            this.Timeout ?? ClientOptions.DefaultTimeout
+        );
         using var cts = CancellationTokenSource.CreateLinkedTokenSource(
             timeoutCts.Token,
             cancellationToken

src/ArcadeDotnet/Core/ClientOptions.cs

@@ -6,6 +6,10 @@ namespace ArcadeDotnet.Core;
 
 public struct ClientOptions()
 {
+    public static readonly int DefaultMaxRetries = 2;
+
+    public static readonly TimeSpan DefaultTimeout = TimeSpan.FromMinutes(1);
+
     public HttpClient HttpClient { get; set; } = new();
 
     Lazy<Uri> _baseUrl = new(() =>
@@ -19,9 +23,9 @@ public Uri BaseUrl
 
     public bool ResponseValidation { get; set; } = false;
 
-    public int MaxRetries { get; set; } = 2;
+    public int? MaxRetries { get; set; }
 
-    public TimeSpan Timeout { get; set; } = TimeSpan.FromMinutes(1);
+    public TimeSpan? Timeout { get; set; }
 
     /// <summary>
     /// API key used for authorization in header

src/ArcadeDotnet/Core/HttpResponse.cs

@@ -1,4 +1,5 @@
 using System;
+using System.IO;
 using System.Net.Http;
 using System.Text.Json;
 using System.Threading;
@@ -22,7 +23,7 @@ public async Task<T> Deserialize<T>(CancellationToken cancellationToken = defaul
         try
         {
             return JsonSerializer.Deserialize<T>(
-                    await Message.Content.ReadAsStreamAsync(cts.Token).ConfigureAwait(false),
+                    await this.ReadAsStream(cts.Token).ConfigureAwait(false),
                     ModelBase.SerializerOptions
                 ) ?? throw new ArcadeInvalidDataException("Response cannot be null");
         }
@@ -32,6 +33,15 @@ await Message.Content.ReadAsStreamAsync(cts.Token).ConfigureAwait(false),
         }
     }
 
+    public async Task<Stream> ReadAsStream(CancellationToken cancellationToken = default)
+    {
+        using var cts = CancellationTokenSource.CreateLinkedTokenSource(
+            this.CancellationToken,
+            cancellationToken
+        );
+        return await Message.Content.ReadAsStreamAsync(cts.Token).ConfigureAwait(false);
+    }
+
     public async Task<string> ReadAsString(CancellationToken cancellationToken = default)
     {
         using var cts = CancellationTokenSource.CreateLinkedTokenSource(

src/ArcadeDotnet/Core/ParamsBase.cs

@@ -194,7 +194,10 @@ protected static void AddDefaultHeaders(HttpRequestMessage request, ClientOption
         {
             request.Headers.Add("Authorization", options.APIKey);
         }
-        request.Headers.Add("X-Stainless-Timeout", options.Timeout.TotalSeconds.ToString());
+        request.Headers.Add(
+            "X-Stainless-Timeout",
+            (options.Timeout ?? ClientOptions.DefaultTimeout).TotalSeconds.ToString()
+        );
     }
 
     static string GetUserAgent() => $"{typeof(ArcadeClient).Name}/C# {GetPackageVersion()}";

src/ArcadeDotnet/IArcadeClient.cs

@@ -15,9 +15,9 @@ public interface IArcadeClient
 
     bool ResponseValidation { get; init; }
 
-    int MaxRetries { get; init; }
+    int? MaxRetries { get; init; }
 
-    TimeSpan Timeout { get; init; }
+    TimeSpan? Timeout { get; init; }
 
     /// <summary>
     /// API key used for authorization in header