Fixed warnings from reproducibility audit#99
Open
braebigge wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to address a few small changes found in a reproducibility audit. I primarily addressed these by adding additional documentation regarding API calls. None of these changes should affect the functionality of the pipeline.
--rerun-incompleteflag usually resolves this"), but a reproducer running this months or years later may encounter failures.key_protidsstill requires Foldseek API calls: InSnakefilelines 586–591,get_aggregate_features_input()expandsaggregate_foldseek_fraction_seq_identityandcalculate_concordanceforKEY_PROTIDSas a common input (not search-mode-only). This triggers therun_foldseekrule (a web API call) for each key_protid even in cluster mode. The README's cluster mode documentation (lines 119–168) does not mention this network requirement, which may surprise users who expect cluster mode to be fully offline.setup.pyfile, which isn't currently used.