Commit 38982f9
committed
PlaywrightProvider: self-contain CLAUDE_SANDBOX_NO_PROXY + forward via sudo env wrapper
Two Devin review findings:
1. binprovider_playwright.py imported CLAUDE_SANDBOX_NO_PROXY from
binprovider_puppeteer.py, violating the "each binprovider owns its
own provider-specific logic" rule in AGENTS.md. Define the constant
locally instead.
2. exec() already wraps commands with /usr/bin/env KEY=VAL so that
PLAYWRIGHT_BROWSERS_PATH survives sudo's env_reset, but the
NO_PROXY / no_proxy values set by ENV were not being forwarded via
the same mechanism -- sudo stripped them before reaching playwright,
defeating the sandbox NO_PROXY fix on Linux (where euid=0 routes
every subprocess through sudo -n). Forward NO_PROXY/no_proxy as
CLI-arg assignments alongside PLAYWRIGHT_BROWSERS_PATH.1 parent 85106ad commit 38982f9
1 file changed
Lines changed: 14 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
| |||
319 | 323 | | |
320 | 324 | | |
321 | 325 | | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
322 | 335 | | |
323 | 336 | | |
324 | 337 | | |
| |||
0 commit comments