Commit a464e53
committed
PuppeteerProvider uninstall: forward install_args to browser-path resolver
``default_uninstall_handler`` derived ``browser_name`` from the caller's
``install_args`` but then called ``_resolve_installed_browser_path``
without forwarding them. The resolver re-runs ``get_install_args``
internally and, when the caller passed an alias that differs from the
provider's registered overrides (e.g. ``chrome`` → ``chromium@latest``),
picks a different ``browser_name`` than the one we just derived. The
subsequent ``parent.name == browser_name`` match against the resolved
path then fails silently, skipping the rmtree and leaking the browser
cache to disk.
Forward the already-resolved ``install_args`` so both derivations stay
in sync.1 parent 7cbe281 commit a464e53
1 file changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
824 | 824 | | |
825 | 825 | | |
826 | 826 | | |
827 | | - | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
828 | 837 | | |
829 | 838 | | |
830 | 839 | | |
| |||
0 commit comments