Skip to content

Add support for home-centered inclusion circle fence#1625

Merged
peterbarker merged 1 commit into
ArduPilot:masterfrom
Ryanf55:fence-home-centered-display
Apr 29, 2026
Merged

Add support for home-centered inclusion circle fence#1625
peterbarker merged 1 commit into
ArduPilot:masterfrom
Ryanf55:fence-home-centered-display

Conversation

@Ryanf55

@Ryanf55 Ryanf55 commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Implementation of mavlink/mavlink#2346

Paired with ArduPilot/ardupilot#31064

image

@srmainwaring

Copy link
Copy Markdown
Contributor

Would be good if this could be sync'd with the params from the simple cylindrical fence in ArduPilot.

@Ryanf55
Ryanf55 force-pushed the fence-home-centered-display branch from 2cab7d5 to 2a93a61 Compare January 19, 2026 01:24
@peterbarker
peterbarker force-pushed the fence-home-centered-display branch from 2a93a61 to 999e52a Compare April 25, 2026 06:11
@Ryanf55
Ryanf55 force-pushed the fence-home-centered-display branch from 0667483 to 2c3b971 Compare April 25, 2026 14:13
@Ryanf55
Ryanf55 marked this pull request as ready for review April 25, 2026 14:13
@Ryanf55

Ryanf55 commented Apr 25, 2026

Copy link
Copy Markdown
Contributor Author

Pulled in Peter's move-home support, cleaned commits. Ready for merge assuming the linters pass.

@peterbarker peterbarker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI must pass

@peterbarker peterbarker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI must pass

@Ryanf55
Ryanf55 force-pushed the fence-home-centered-display branch from 2c3b971 to ed79414 Compare April 26, 2026 03:39
@peterbarker

Copy link
Copy Markdown
Contributor

@Ryanf55 did you re-test this?

@peterbarker

Copy link
Copy Markdown
Contributor

Throws an error about uploading floating point values when actually used

@Ryanf55

Ryanf55 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Throws an error about uploading floating point values when actually used

I fixed in 0e82c65. I'll squash if you are ready for that.
Depending on the order you sent the fence vs list it, you can avoid the bug.
Yes, it seems odd to populate lat/lon there, but you need to do it because display_polyfences_inclusion_circles calls circles_of_type. If you don't populate p.x and p.y for the scaled home value, it shows up at 0,0 global coords.

Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
@peterbarker
peterbarker force-pushed the fence-home-centered-display branch from 5287845 to 893e3f4 Compare April 28, 2026 07:10
@peterbarker

Copy link
Copy Markdown
Contributor

I've adjusted this branch to handle home change slightly differently so we don't need to munge before the map library sees things. Also means we can render the circle in a slightly different colour.

I'm going to merge this if you don't have objections, @Ryanf55 :-)

@peterbarker
peterbarker merged commit 904f2ce into ArduPilot:master Apr 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants