feat(motor test): Make the motor test application more pythonic

It now raises exceptions that the frontend should catch and display to the user.
The motor diagrams are all png now, I've given up on svg. They're to hard to render correctly

Author: amilcarlucas

ARCHITECTURE_motor_test.md

@@ -68,8 +68,10 @@ def _get_settings_defaults(cls) -> dict[str, Union[int, bool, str, float, dict]]
             "annotate_docs_into_param_files": False,
             "gui_complexity": "simple",  # simple or normal
             # Motor test settings
-            "motor_test_duration": 2.5,  # Default test duration in seconds
-            "motor_test_throttle_pct": 10,  # Default throttle percentage (10%)
+            "motor_test": {
+                "duration": 2.5,  # Default test duration in seconds
+                "throttle_pct": 10,  # Default throttle percentage (10%)
+            },
         }
 
     @staticmethod
@@ -341,14 +343,14 @@ def set_setting(setting: str, value: Union[bool, str, float]) -> None:
     @staticmethod
     def motor_diagram_filepath(frame_class: int, frame_type: int) -> tuple[str, str]:
         """
-        Get the filepath for the motor diagram SVG file.
+        Get the filepath for the motor diagram PNG file.
 
         Args:
             frame_class: ArduPilot frame class (1=QUAD, 2=HEXA, etc.)
             frame_type: ArduPilot frame type (0=PLUS, 1=X, etc.)
 
         Returns:
-            str: Absolute path to the motor diagram SVG file
+            str: Absolute path to the motor diagram PNG file
             str: Error message if multiple or no files found, empty string if no error
 
         """
@@ -361,12 +363,12 @@ def motor_diagram_filepath(frame_class: int, frame_type: int) -> tuple[str, str]
             # Running as script
             application_path = os_path.dirname(os_path.dirname(os_path.abspath(__file__)))
 
-        images_dir = os_path.join(application_path, "ardupilot_methodic_configurator", "images")
+        images_dir = os_path.join(application_path, "ardupilot_methodic_configurator", "images", "motor_diagrams_png")
 
-        # Generate SVG filename based on frame configuration
-        filename = f"m_{frame_class:02d}_{frame_type:02d}_*.svg"
+        # Generate PNG filename based on frame configuration
+        filename = f"m_{frame_class:02d}_{frame_type:02d}_*.png"
 
-        # Search for matching SVG file (since exact naming varies)
+        # Search for matching PNG file (since exact naming varies)
         matching_files = glob.glob(os_path.join(images_dir, filename))
 
         err_msg = (

ardupilot_methodic_configurator/backend_filesystem_program_settings.py

@@ -714,6 +714,43 @@ def set_param(self, param_name: str, param_value: float) -> None:
             return
         self.master.param_set_send(param_name, param_value)
 
+    def fetch_param(self, param_name: str, timeout: int = 5) -> Optional[float]:
+        """
+        Fetch a parameter from the flight controller using MAVLink PARAM_REQUEST_READ message.
+
+        Args:
+            param_name (str): The name of the parameter to fetch.
+            timeout (int): Timeout in seconds to wait for the response. Default is 5.
+
+        Returns:
+            float: The value of the parameter, or None if not found or timeout occurred.
+
+        """
+        if self.master is None:  # FIXME for testing only pylint: disable=fixme
+            return None
+
+        # Send PARAM_REQUEST_READ message
+        self.master.mav.param_request_read_send(
+            self.master.target_system,
+            self.master.target_component,
+            param_name.encode("utf-8"),
+            -1,  # param_index: -1 means use param_id instead
+        )
+
+        # Wait for PARAM_VALUE response
+        start_time = time_time()
+        while time_time() - start_time < timeout:
+            msg = self.master.recv_match(type="PARAM_VALUE", blocking=False)
+            if msg is not None:
+                # Check if this is the parameter we requested
+                received_param_name = msg.param_id.rstrip("\x00")
+                if received_param_name == param_name:
+                    logging_debug(_("Received parameter: %s = %s"), param_name, msg.param_value)
+                    return float(msg.param_value)
+            time_sleep(0.01)  # Small sleep to prevent busy waiting
+
+        raise TimeoutError(_("Timeout waiting for parameter %s") % param_name)
+
     def reset_all_parameters_to_default(self) -> tuple[bool, str]:
         """
         Reset all parameters to their factory default values.