refactor(flightcontroller): Use DRY in the baudrate property

Author: amilcarlucas

ardupilot_methodic_configurator/backend_flightcontroller.py

@@ -123,7 +123,6 @@ def __init__(  # pylint: disable=too-many-arguments, too-many-positional-argumen
             logging_warning(_("You should uninstall ModemManager as it conflicts with ArduPilot"))
 
         self._reboot_time = reboot_time
-        self._baudrate = baudrate
         self._network_ports = network_ports if network_ports is not None else FlightControllerConnection.DEFAULT_NETWORK_PORTS
 
         # Component managers (delegation pattern with dependency injection support)
@@ -132,7 +131,7 @@ def __init__(  # pylint: disable=too-many-arguments, too-many-positional-argumen
         # Share the same FlightControllerInfo instance across all managers
         _info = info or FlightControllerInfo()
         self._connection_manager: FlightControllerConnectionProtocol = connection_manager or FlightControllerConnection(
-            info=_info, baudrate=self._baudrate, network_ports=self._network_ports
+            info=_info, baudrate=baudrate, network_ports=self._network_ports
         )
 
         self._params_manager: FlightControllerParamsProtocol = params_manager or FlightControllerParams(
@@ -210,8 +209,8 @@ def reboot_time(self) -> int:
 
     @property
     def baudrate(self) -> int:
-        """Get the baudrate setting."""
-        return self._baudrate
+        """Get the baudrate setting - delegates to connection manager."""
+        return self._connection_manager.baudrate
 
     @property
     def PARAM_FETCH_POLL_DELAY(self) -> float:  # noqa: N802 # pylint: disable=invalid-name
@@ -290,7 +289,7 @@ def reset_and_reconnect(
             reset_progress_callback(current_step, sleep_time)
 
         # Reconnect to the flight controller
-        return self.create_connection_with_retry(connection_progress_callback, baudrate=self._baudrate)
+        return self.create_connection_with_retry(connection_progress_callback, baudrate=self.baudrate)
 
     def discover_connections(self) -> None:
         """Discover available connections - delegates to connection manager."""

ardupilot_methodic_configurator/backend_flightcontroller_connection.py

@@ -940,6 +940,11 @@ def comport_device(self) -> str:
             return ""
         return str(self.comport.device)
 
+    @property
+    def baudrate(self) -> int:
+        """Get the default baud rate for serial connections."""
+        return self._baudrate
+
     def set_master_for_testing(
         self,
         master: Optional[mavutil.mavlink_connection],  # pyright: ignore[reportGeneralTypeIssues]

ardupilot_methodic_configurator/backend_flightcontroller_protocols.py

@@ -89,6 +89,11 @@ def comport(self) -> Union[mavutil.SerialPort, serial.tools.list_ports_common.Li
     @property
     def comport_device(self) -> str: ...
 
+    @property
+    def baudrate(self) -> int:
+        """Get the default baud rate for serial connections."""
+        ...  # pylint: disable=unnecessary-ellipsis
+
     def discover_connections(self) -> None: ...
 
     def disconnect(self) -> None: ...