fix: copilot suggestions

Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>

Author: OmkarSarkar204

ardupilot_methodic_configurator/data_model_configuration_step.py

@@ -348,7 +348,12 @@ def _generate_connection_renames(parameters: list[str], new_connection_prefix: s
                 old_prefix += "_" + parts[1]
                 new_prefix = "CAN_D" + new_number
                 is_exception_case = True
-            if new_type == "SERIAL" and len(parts) >= 2 and parts[0] == "BRD" and re.match(r"^SER\d+$", parts[1]):
+            if (
+                new_type == "SERIAL"
+                and len(parts) >= 2
+                and parts[0] == "BRD"
+                and re.match(r"^SER\d+$", parts[1])  # codespell:ignore
+            ):
                 old_prefix += "_" + parts[1]
                 new_prefix = "BRD_SER" + new_number
                 is_exception_case = True

ardupilot_methodic_configurator/extract_param_defaults.py

@@ -4,8 +4,6 @@
 """
 Extracts parameter values or parameter default values from an ArduPilot .bin log file.
 
-Supports Mission Planner, MAVProxy and QGCS file format output
-
 Currently has 95% unit test coverage
 
 SPDX-FileCopyrightText: 2024-2026 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
@@ -261,8 +259,8 @@ def extract_firmware_version_and_vehicle_type(logfile: str) -> tuple[str, int, i
                 result = process_ver(m)
                 if result is not None:
                     return result
-                continue
-            msg_fallback_result = process_msg_version_fallback(m, msg_fallback_result)
+            elif m.get_type() == "MSG":
+                msg_fallback_result = process_msg_version_fallback(m, msg_fallback_result)
 
         if msg_fallback_result is not None:
             return msg_fallback_result

ardupilot_methodic_configurator/log_analysis/__init__.py

@@ -1,7 +1,7 @@
 """
 ArduPilot log analysis module.
 
-Parses and analyses ArduPilot .bin log files to extract parameters,firmware information, and telemetry data.
+Parses and analyses ArduPilot .bin log files to extract parameters, firmware information, and telemetry data.
 
 This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 

ardupilot_methodic_configurator/log_analysis/backend_log_extraction.py

@@ -1,8 +1,6 @@
 """
 Parses an ArduPilot .bin log file, and extracts all the parameters required for analysing the log.
 
-Supports Mission Planner, MAVProxy and QGCS file format output
-
 SPDX-FileCopyrightText: 2024-2026 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 
 SPDX-License-Identifier: GPL-3.0-or-later
@@ -43,7 +41,7 @@ def open_log(logfile: str) -> mavutil.mavfile:
         mlog = mavutil.mavlink_connection(logfile)
     except Exception as e:
         msg = f"Error opening the {logfile} logfile: {e!s}"
-        raise SystemExit(msg) from e
+        raise OSError(msg) from e
     return mlog  # pyright: ignore[reportReturnType]  # pymavlink stubs include CSVReader which doesn't extend mavfile
 
 
@@ -59,7 +57,7 @@ def close_log(mlog: mavutil.mavfile) -> None:
         mlog.close()
 
 
-class LogData:
+class LogData:  # pylint: disable=too-few-public-methods
     """Contains all data extracted from an ArduPilot .bin log."""
 
     def __init__(self) -> None:
@@ -70,7 +68,7 @@ def __init__(self) -> None:
         self.frame_type: int | None = None
 
 
-class LogReader:
+class LogReader:  # pylint: disable=too-few-public-methods
     """Reader for Ardupilot log files, sending each message to its appropriate function."""
 
     def __init__(self, logfile: str) -> None:
@@ -131,7 +129,7 @@ def process_param(msg: mavutil.mavfile, log_data: LogData) -> None:
     default_params and current_params from the message's Default and Value fields.
 
     Args:
-      msg: A parsed MAVLink message.
+      msg: A PARM log entry parsed from an ArduPilot .bin file.
       log_data: The LogData instance to write param value into.
 
     """
@@ -152,10 +150,10 @@ def process_param(msg: mavutil.mavfile, log_data: LogData) -> None:
 
 def process_ver(msg: mavutil.mavfile) -> tuple[str, int, int, int] | None:
     """
-    Extract firmware version form VER message.
+    Extract firmware version from VER message.
 
     Args:
-      msg: A parsed MAVLink message.
+      msg: A VER log entry parsed from an ArduPilot .bin file.
 
     Returns:
       A tuple of (vehicle_type, major, minor, patch), e.g. ("ArduCopter", 4, 6, 3).
@@ -174,13 +172,13 @@ def process_msg_version_fallback(
     msg: mavutil.mavfile, firmware_from_msg: tuple[str, int, int, int] | None
 ) -> tuple[str, int, int, int] | None:
     """
-    Extract firmware version form MSG message.
+    Extract firmware version from MSG message.
 
     Falls back to scanning MSG messages until one with a parseable "Vx.y" version
     is found (e.g. "ArduCopter V4.6.3 (hash)").
 
     Args:
-      msg: A parsed MAVLink message.
+      msg: A MSG log entry parsed from an ArduPilot .bin file.
       firmware_from_msg: If any previously found message from MSG, or None.
 
     Returns: