refactor(component validation): the TOW validation into a helper to bring nr of return statements down.

Author: amilcarlucas

ardupilot_methodic_configurator/data_model_vehicle_components_validation.py

@@ -423,6 +423,26 @@ def _update_possible_choices_for_path(  # pylint: disable=too-many-branches
                     tuple(gnss_available_protocols) if gnss_available_protocols else ("None",)
                 )
 
+    def _validate_tow_limits(self, value: str, path: ComponentPath) -> tuple[str, Optional[float]]:
+        """Validate takeoff weight min/max cross-constraints."""
+        if path[2] == "TOW max Kg":
+            try:
+                tow_max = float(value)
+            except ValueError:
+                return _("Takeoff Weight max must be a float"), None
+            lim = self.get_component_value(("Frame", "Specifications", "TOW min Kg"))
+            if lim:
+                return self.validate_against_another_value(tow_max, lim, "TOW min Kg", above=True, delta=0.01)
+        if path[2] == "TOW min Kg":
+            try:
+                tow_min = float(value)
+            except ValueError:
+                return _("Takeoff Weight min must be a float"), None
+            lim = self.get_component_value(("Frame", "Specifications", "TOW max Kg"))
+            if lim:
+                return self.validate_against_another_value(tow_min, lim, "TOW max Kg", above=False, delta=0.01)
+        return "", None
+
     def validate_entry_limits(self, value: str, path: ComponentPath) -> tuple[str, Optional[float]]:
         """
         Validate entry values against limits.
@@ -445,23 +465,7 @@ def validate_entry_limits(self, value: str, path: ComponentPath) -> tuple[str, O
 
             # Validate takeoff weight limits
             if path[0] == "Frame" and path[1] == "Specifications" and "TOW" in path[2]:
-                if path[2] == "TOW max Kg":
-                    try:
-                        tow_max = float(value)
-                    except ValueError:
-                        return _("Takeoff Weight max must be a float"), None
-                    lim = self.get_component_value(("Frame", "Specifications", "TOW min Kg"))
-                    if lim:
-                        return self.validate_against_another_value(tow_max, lim, "TOW min Kg", above=True, delta=0.01)
-
-                if path[2] == "TOW min Kg":
-                    try:
-                        tow_min = float(value)
-                    except ValueError:
-                        return _("Takeoff Weight min must be a float"), None
-                    lim = self.get_component_value(("Frame", "Specifications", "TOW max Kg"))
-                    if lim:
-                        return self.validate_against_another_value(tow_min, lim, "TOW max Kg", above=False, delta=0.01)
+                return self._validate_tow_limits(value, path)
 
         if path in BATTERY_CELL_VOLTAGE_PATHS:
             return self.validate_cell_voltage(value, path)