fix(mypy): Fix mypy findings

Author: amilcarlucas

ardupilot_methodic_configurator/backend_filesystem_configuration_steps.py

@@ -22,7 +22,7 @@
 from jsonschema.exceptions import ValidationError
 
 from ardupilot_methodic_configurator import _
-from ardupilot_methodic_configurator.data_model_par_dict import Par
+from ardupilot_methodic_configurator.data_model_par_dict import Par, ParDict
 
 
 class ConfigurationSteps:
@@ -42,8 +42,8 @@ def __init__(self, _vehicle_dir: str, vehicle_type: str) -> None:
         self.configuration_steps_filename = "configuration_steps_" + vehicle_type + ".json"
         self.configuration_steps: dict[str, dict] = {}
         self.configuration_phases: dict[str, dict] = {}
-        self.forced_parameters: dict[str, dict] = {}
-        self.derived_parameters: dict[str, dict] = {}
+        self.forced_parameters: dict[str, ParDict] = {}
+        self.derived_parameters: dict[str, ParDict] = {}
         self.log_loaded_file = False
 
     def re_init(self, vehicle_dir: str, vehicle_type: str) -> None:  # pylint: disable=too-many-branches
@@ -188,7 +188,7 @@ def compute_parameters(self, filename: str, file_info: dict, parameter_type: str
                         continue
 
                 if filename not in destination:
-                    destination[filename] = {}
+                    destination[filename] = ParDict()
                 change_reason = _(parameter_info["Change Reason"]) if parameter_info["Change Reason"] else ""
                 destination[filename][parameter] = Par(float(result), change_reason)
             except (SyntaxError, NameError, KeyError, StopIteration) as _e:

ardupilot_methodic_configurator/backend_flightcontroller.py

@@ -539,10 +539,10 @@ def download_params(
             filename = "params.param"
             logging_warning(_("Testing active, will load all parameters from the %s file"), filename)
             par_dict_with_comments = ParDict.load_param_file_into_dict(filename)
-            return {k: v.value for k, v in par_dict_with_comments.items()}, {}
+            return {k: v.value for k, v in par_dict_with_comments.items()}, ParDict()
 
         if self.master is None:
-            return {}, {}
+            return {}, ParDict()
 
         # Check if MAVFTP is supported
         comport_device = getattr(self.comport, "device", "")
@@ -554,7 +554,7 @@ def download_params(
                 return param_dict, default_param_dict
 
         logging_info(_("MAVFTP is not supported by the %s flight controller, fallback to MAVLink"), comport_device)
-        return self.__download_params_via_mavlink(progress_callback), {}
+        return self.__download_params_via_mavlink(progress_callback), ParDict()
 
     def __download_params_via_mavlink(
         self, progress_callback: Union[None, Callable[[int, int], None]] = None

ardupilot_methodic_configurator/data_model_configuration_step.py

@@ -17,6 +17,7 @@
 from ardupilot_methodic_configurator import _
 from ardupilot_methodic_configurator.backend_filesystem import LocalFilesystem
 from ardupilot_methodic_configurator.data_model_ardupilot_parameter import ArduPilotParameter
+from ardupilot_methodic_configurator.data_model_par_dict import ParDict
 
 
 class ConfigurationStepProcessor:
@@ -157,8 +158,8 @@ def _create_domain_model_parameters(
             default_par = self.local_filesystem.param_default_dict.get(param_name, None)
 
             # Check if parameter is forced or derived
-            forced_par = self.local_filesystem.forced_parameters.get(selected_file, {}).get(param_name, None)
-            derived_par = self.local_filesystem.derived_parameters.get(selected_file, {}).get(param_name, None)
+            forced_par = self.local_filesystem.forced_parameters.get(selected_file, ParDict()).get(param_name, None)
+            derived_par = self.local_filesystem.derived_parameters.get(selected_file, ParDict()).get(param_name, None)
 
             # Get FC value if available
             fc_value = fc_parameters.get(param_name)

ardupilot_methodic_configurator/frontend_tkinter_flightcontroller_info.py

@@ -29,7 +29,7 @@ class FlightControllerInfoPresenter:
 
     def __init__(self, flight_controller: FlightController) -> None:
         self.flight_controller = flight_controller
-        self.param_default_values: ParDict = {}
+        self.param_default_values: ParDict = ParDict()
 
     def get_info_data(self) -> dict[str, Union[str, dict[str, str]]]:
         """Get formatted flight controller information for display."""

ardupilot_methodic_configurator/frontend_tkinter_parameter_editor_table.py

@@ -835,7 +835,7 @@ def get_upload_selected_params(self, current_file: str, gui_complexity: str) ->
             # all parameters are selected for upload in simple mode
             return self.local_filesystem.file_parameters[current_file]
 
-        selected_params = {}
+        selected_params = ParDict()
         for param_name, checkbutton_state in self.upload_checkbutton_var.items():
             if checkbutton_state.get():
                 selected_params[param_name] = self.local_filesystem.file_parameters[current_file][param_name]