fix(configuration_steps): Only report deleted parameters if they existed in the file

Author: amilcarlucas

ardupilot_methodic_configurator/backend_filesystem.py

@@ -926,7 +926,11 @@ def calculate_derived_and_forced_param_changes(
                 )
 
                 # Apply deletions from delete_parameters
-                for param_name in self.compute_deletions(param_filename, step_dict, eval_variables):
+                to_delete = self.compute_deletions(param_filename, step_dict, eval_variables)
+                actually_deleted = [p for p in sorted(to_delete) if p in working]
+                if actually_deleted:
+                    logging_info(_("Deleting parameters %s from '%s'"), actually_deleted, param_filename)
+                for param_name in to_delete:
                     working.pop(param_name, None)
 
             # Include in computed_changes if the working copy differs from the loaded in-memory state

ardupilot_methodic_configurator/backend_filesystem_configuration_steps.py

@@ -553,8 +553,6 @@ def compute_deletions(self, filename: str, file_info: dict, variables: dict) ->
                 continue
             if self._condition_passes(parameter_info, variables):
                 to_delete.add(parameter)
-        if to_delete:
-            logging_info(_("Deleting parameters %s from '%s'"), sorted(to_delete), filename)
         return to_delete
 
     def auto_changed_by(self, selected_file: str) -> str:

ardupilot_methodic_configurator/data_model_parameter_editor.py

@@ -1774,7 +1774,11 @@ def _repopulate_configuration_step_parameters(  # pylint: disable=too-many-local
             # Apply deletions - remove parameters from domain model and track them.
             # Note: compute_deletions is also called in calculate_derived_and_forced_param_changes to
             # update the pre-computed filesystem working copy; this separate call updates the live UI domain model.
-            for param_name in self._local_filesystem.compute_deletions(self.current_file, step_info, variables):
+            to_delete = self._local_filesystem.compute_deletions(self.current_file, step_info, variables)
+            actually_deleted = [p for p in sorted(to_delete) if p in self.current_step_parameters]
+            if actually_deleted:
+                logging_info(_("Deleting parameters %s from '%s'"), actually_deleted, self.current_file)
+            for param_name in to_delete:
                 if param_name in self.current_step_parameters:
                     self._deleted_parameters.add(param_name)
                     del self.current_step_parameters[param_name]