fix(configuration_step): Warn instead of crashing

Author: amilcarlucas

ardupilot_methodic_configurator/data_model_configuration_step.py

@@ -13,13 +13,17 @@
 
 import re
 from logging import info as logging_info
+from logging import warning as logging_warning
 from typing import Any, Optional
 
 from ardupilot_methodic_configurator import _
 from ardupilot_methodic_configurator.backend_filesystem import LocalFilesystem
 from ardupilot_methodic_configurator.data_model_ardupilot_parameter import ArduPilotParameter
 from ardupilot_methodic_configurator.data_model_par_dict import Par, ParDict, is_within_tolerance
-from ardupilot_methodic_configurator.data_model_safe_evaluator import safe_evaluate
+from ardupilot_methodic_configurator.data_model_safe_evaluator import (
+    ConfigurationStepEvalError,
+    safe_evaluate,
+)
 
 
 class ConfigurationStepProcessor:
@@ -200,9 +204,16 @@ def _handle_connection_renaming(
             return [], set(), []
 
         # Calculate rename operations WITHOUT mutating file_parameters
-        duplicated_parameters, renamed_pairs = self._calculate_connection_rename_operations(
-            self.local_filesystem.file_parameters[selected_file], new_connection_prefix, variables
-        )
+        try:
+            duplicated_parameters, renamed_pairs = self._calculate_connection_rename_operations(
+                self.local_filesystem.file_parameters[selected_file], new_connection_prefix, variables
+            )
+        except ConfigurationStepEvalError as exc:
+            logging_warning(
+                _("Skipping connection renaming because evaluation failed: %s"),
+                str(exc),
+            )
+            return [], set(), []
 
         ui_infos: list[tuple[str, str]] = []
 

tests/test_data_model_configuration_step.py

@@ -265,6 +265,30 @@ def test_user_can_rename_connection_parameters_successfully(self, processor, fc_
         assert ui_errors == []
         assert isinstance(parameters, dict)
 
+    def test_optional_connection_lookup_missing_does_not_crash(self, processor, fc_parameters) -> None:
+        """
+        Connection renaming should be skipped when an optional component lookup is missing.
+
+        GIVEN: A rename_connection expression referring to a missing optional vehicle component
+        WHEN: The configuration step is processed
+        THEN: Processing should complete without raising an exception
+        AND: No rename operations should be applied
+        """
+        selected_file = "test_file.param"
+        processor.local_filesystem.configuration_steps = {
+            selected_file: {"rename_connection": "vehicle_components['GNSS Receiver']['FC Connection']['Type']"}
+        }
+
+        parameters, ui_errors, ui_infos, duplicates_to_remove, renames_to_apply, _ = processor.process_configuration_step(
+            selected_file, fc_parameters
+        )
+
+        assert ui_errors == []
+        assert ui_infos == []
+        assert duplicates_to_remove == set()
+        assert renames_to_apply == []
+        assert isinstance(parameters, dict)
+
     def test_user_receives_feedback_about_duplicate_parameter_removal(self, processor, fc_parameters) -> None:
         """
         User receives clear feedback when duplicate parameters are removed during renaming.