You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
***Security Scanning**: Automated vulnerability detection via [CodeQL](https://github.com/ArduPilot/MethodicConfigurator/actions/workflows/codeql.yml) and dependency reviews
129
+
***Testing**: Comprehensive test suite execution with [pytest](https://github.com/ArduPilot/MethodicConfigurator/actions/workflows/pytest.yml)
130
+
131
+
### Manual Review Criteria
132
+
133
+
We manually verify the following aspects:
134
+
135
+
#### Code Quality & Standards
136
+
137
+
* Does the code follow our [coding standards](https://ardupilot.github.io/MethodicConfigurator/COMPLIANCE#coding-standards)
138
+
and [PEP 8](https://peps.python.org/pep-0008/) guidelines?
139
+
* Is the code well-documented with appropriate docstrings and comments?
140
+
* Does it include comprehensive error handling and logging?
141
+
* Are there any code smells, technical debt, or maintainability issues?
142
+
* Do the [git commit messages follow conventional commit standards](https://www.conventionalcommits.org/en/v1.0.0/)?
143
+
* Is at least the last commit in the pull request branch [signed off](https://developercertificate.org/) by the contributor?
144
+
* Does the pull request have a clear description of the changes and their rationale?
145
+
* Is the pull request branch free of merge commits?
146
+
147
+
#### Architecture & Design
148
+
149
+
* Does the change follow our [architecture guidelines](https://github.com/ArduPilot/MethodicConfigurator/blob/master/ARCHITECTURE.md)?
150
+
* Is there proper separation of concerns (backend, business logic, frontend/GUI)?
151
+
* Is the code modular, testable, and maintainable?
152
+
* Does it follow object-oriented design principles and [clean code practices](https://www.oreilly.com/library/view/clean-code/9780136083238/)?
153
+
154
+
#### Functionality & Testing
155
+
156
+
* Is it generic enough to be useful for multiple use cases?
157
+
* Does the change include appropriate unit tests and integration tests?
158
+
* Are edge cases and error conditions properly tested?
159
+
* Does it maintain or improve [test coverage](https://coveralls.io/github/ArduPilot/MethodicConfigurator)?
160
+
* Have manual testing scenarios been considered?
161
+
162
+
#### Security & Compliance
163
+
164
+
* Does the change follow [secure coding practices](https://ardupilot.github.io/MethodicConfigurator/SECURITY)?
165
+
* Does it comply with our [license requirements](https://github.com/ArduPilot/MethodicConfigurator/blob/master/LICENSE.md) and [REUSE specification](https://reuse.software/spec-3.3/)?
166
+
167
+
#### User Experience & Documentation
168
+
169
+
* Does the change maintain or improve usability?
170
+
* Is user-facing documentation updated (including translations)?
171
+
* Are there any breaking changes that need documentation?
172
+
* New strings must be properly internationalized with `_( ... )`
173
+
174
+
#### Community & Process
175
+
176
+
* Does the change violate our [code of conduct](https://github.com/ArduPilot/MethodicConfigurator/blob/master/CODE_OF_CONDUCT.md)?
177
+
105
178
## Development Team
106
179
107
180
The ArduPilot Methodic Configurator project is open-source and maintained by a team of volunteers.
108
181
109
-
New developers are recommended to join the `#general`channel on
182
+
New developers are recommended to join the `#general`and `#methodic_configurator` channels on
110
183
[Discord](https://ardupilot.org/discord).
111
184
112
185
You can also join the
113
186
[development discussion on Discourse](https://discuss.ardupilot.org/c/development-team).
114
187
115
188
Note that these are NOT for user tech support, and are moderated
- git pre-commit hooks for code linting and other code quality checks
131
+
-[git pre-commit hooks](https://github.com/ArduPilot/MethodicConfigurator/blob/master/.pre-commit-config.yaml) for code linting and other code quality checks
132
132
- create command-line autocompletion for bash, zsh and powershell [PR #134](https://github.com/ArduPilot/MethodicConfigurator/pull/134)
0 commit comments