test(frontend_tkinter): Address copilot review suggestions

Author: amilcarlucas

tests/test_frontend_tkinter_about_popup_window.py

@@ -12,26 +12,11 @@
 
 import contextlib
 import tkinter as tk
-from collections.abc import Generator
 from unittest.mock import patch
 from urllib.parse import urlparse
 
-import pytest
-
 from ardupilot_methodic_configurator.frontend_tkinter_about_popup_window import AboutWindow
 
-# pylint: disable=redefined-outer-name
-
-
-@pytest.fixture
-def root() -> Generator[tk.Tk, None, None]:
-    """Provide a hidden Tk root window for tests."""
-    root = tk.Tk()
-    root.withdraw()
-    yield root
-    root.update_idletasks()
-    root.destroy()
-
 
 def _create_about_window(root: tk.Tk, version: str = "1.2.3") -> AboutWindow:
     """Helper to create an AboutWindow with all heavy operations mocked."""
@@ -43,6 +28,10 @@ def _create_about_window(root: tk.Tk, version: str = "1.2.3") -> AboutWindow:
             return_value=1.0,
         ),
         patch("ardupilot_methodic_configurator.frontend_tkinter_base_window.BaseWindow.center_window"),
+        patch(
+            "ardupilot_methodic_configurator.backend_filesystem_program_settings.ProgramSettings.display_usage_popup",
+            return_value=True,
+        ),
     ):
         return AboutWindow(root, version)
 
@@ -279,10 +268,12 @@ def test_user_can_view_source_code_via_about_window(self, root: tk.Tk) -> None:
             mock_open.assert_called_once()
             call_args = mock_open.call_args[0][0]
             assert isinstance(call_args, str), f"Expected URL string but got {type(call_args)}"
-            assert "github.com/ArduPilot/MethodicConfigurator" in call_args, (
-                f"Expected repository URL not found in {call_args}"
-            )
             assert call_args.startswith("http"), f"URL should start with http but got {call_args}"
+            parsed_url = urlparse(call_args)
+            host = parsed_url.hostname
+            assert host is not None, f"GitHub URL host not found in {call_args}"
+            assert host == "github.com" or host.endswith(".github.com"), f"GitHub URL not found in {call_args}"
+            assert "ArduPilot/MethodicConfigurator" in parsed_url.path, f"Expected repository path not found in {call_args}"
 
 
 class TestAboutWindowUsagePopupPreferences:

tests/test_frontend_tkinter_rich_text.py

@@ -206,18 +206,10 @@ def test_get_widget_font_family_and_size(self) -> None:
     unittest.main()
 
 
-class TestRichTextColorAndFontFallbacks(unittest.TestCase):
+class TestRichTextColorAndFontFallbacks:
     """Tests for color and font fallback behavior in RichText."""
 
-    def setUp(self) -> None:
-        self.root = tk.Tk()
-        self.root.withdraw()
-
-    def tearDown(self) -> None:
-        self.root.update_idletasks()
-        self.root.destroy()
-
-    def test_user_can_create_rich_text_with_explicit_background_color(self) -> None:
+    def test_user_can_create_rich_text_with_explicit_background_color(self, root: tk.Tk) -> None:
         """
         User can create RichText with an explicit background color.
 
@@ -226,10 +218,10 @@ def test_user_can_create_rich_text_with_explicit_background_color(self) -> None:
         THEN: The background kwarg should skip the auto-detection
         AND: Widget should use the provided background color
         """
-        rich_text = RichText(self.root, background="red")
+        rich_text = RichText(root, background="red")
         assert rich_text.cget("background") == "red"
 
-    def test_user_can_create_rich_text_with_bg_shorthand(self) -> None:
+    def test_user_can_create_rich_text_with_bg_shorthand(self, root: tk.Tk) -> None:
         """
         User can create RichText with bg shorthand.
 
@@ -238,11 +230,11 @@ def test_user_can_create_rich_text_with_bg_shorthand(self) -> None:
         THEN: The bg kwarg should skip the auto-detection
         AND: Widget should use the provided background color
         """
-        rich_text = RichText(self.root, bg="blue")
+        rich_text = RichText(root, bg="blue")
         # Color may be returned as RGB by Tk on some platforms
         assert rich_text.cget("background")
 
-    def test_user_can_create_rich_text_with_explicit_foreground_color(self) -> None:
+    def test_user_can_create_rich_text_with_explicit_foreground_color(self, root: tk.Tk) -> None:
         """
         User can create RichText with an explicit foreground color.
 
@@ -251,21 +243,21 @@ def test_user_can_create_rich_text_with_explicit_foreground_color(self) -> None:
         THEN: The foreground kwarg should skip auto-detection
         AND: Widget should use provided foreground color
         """
-        rich_text = RichText(self.root, foreground="green")
+        rich_text = RichText(root, foreground="green")
         assert rich_text.cget("foreground")
 
-    def test_user_can_create_rich_text_with_fg_shorthand(self) -> None:
+    def test_user_can_create_rich_text_with_fg_shorthand(self, root: tk.Tk) -> None:
         """
         User can create RichText with fg shorthand.
 
         GIVEN: User wants a custom foreground color using 'fg' alias
         WHEN: RichText is created with fg kwarg
         THEN: Widget should be created successfully
         """
-        rich_text = RichText(self.root, fg="purple")
+        rich_text = RichText(root, fg="purple")
         assert rich_text.cget("foreground")
 
-    def test_user_can_create_rich_text_when_safe_font_nametofont_returns_none(self) -> None:
+    def test_user_can_create_rich_text_when_safe_font_nametofont_returns_none(self, root: tk.Tk) -> None:
         """
         User can create RichText even when safe_font_nametofont returns None.
 
@@ -275,7 +267,7 @@ def test_user_can_create_rich_text_when_safe_font_nametofont_returns_none(self)
         AND: Widget should be created successfully
         """
         with patch("ardupilot_methodic_configurator.frontend_tkinter_rich_text.safe_font_nametofont", return_value=None):
-            rich_text = RichText(self.root)
+            rich_text = RichText(root)
 
         assert rich_text is not None
         assert "bold" in rich_text.tag_names()