fix(ui): center all windows on the active screen on Windows

Add BaseWindow.center_window_on_screen() calls to all 8 main windows
that were missing screen centering after setting their geometry. On
Windows with multi-monitor setups, these windows would appear at
arbitrary positions instead of centering on the active screen (the
monitor where the mouse pointer is located).

Windows now centered:
- Connection Selection
- Software Update Dialog
- Flight Controller Info
- Project Opener (Directory Selection)
- Parameter Editor
- Component Editor
- Template Overview
- Project Creator

The existing center_window_on_screen() method uses the screeninfo
library to detect the monitor containing the mouse pointer and centers
the window on that monitor, with proper bounds clamping.

On Windows, a withdrawn tk.Tk() root can report winfo_width() > 1,
causing ProgressWindow to use parent-relative centering instead of
screen centering. This placed the "Initializing Flight Controller"
progress bar in the top-left corner instead of screen center.

Added winfo_viewable() check alongside the existing winfo_width()
check to reliably detect withdrawn parent windows on all platforms.

Added test to verify screen centering is used when parent is withdrawn.

- Fix center_window_on_screen() to use winfo_width()/winfo_height()
  (actual rendered size) instead of winfo_reqwidth()/winfo_reqheight()
  (natural content size). The previous approach placed the top-left
  corner at screen center because winfo_reqwidth() returned a value
  much smaller than the geometry-set size. Falls back to reqwidth for
  unmapped windows (which return width=1).

- Extract duplicated centering condition in ProgressWindow into
  _center_progress_window() helper to keep logic in one place.

- Rename test method for clarity.

Fixes #1346

Signed-off-by: Yash Goel <yashhzd@users.noreply.github.com>

Author: yashhzd

ardupilot_methodic_configurator/frontend_tkinter_base_window.py

@@ -331,8 +331,14 @@ def center_window_on_screen(window: Union[tk.Toplevel, tk.Tk]) -> None:
         window.update_idletasks()
 
         # Get the window dimensions
-        window_width = window.winfo_reqwidth()
-        window_height = window.winfo_reqheight()
+        # Use winfo_width/height (actual rendered size) like center_window() does.
+        # Fall back to winfo_reqwidth/height for windows not yet mapped (returns 1).
+        window_width = window.winfo_width()
+        window_height = window.winfo_height()
+        if window_width <= 1:
+            window_width = window.winfo_reqwidth()
+        if window_height <= 1:
+            window_height = window.winfo_reqheight()
 
         # Get pointer position to determine which monitor it's on
         pointer_x = window.winfo_pointerx()

ardupilot_methodic_configurator/frontend_tkinter_component_editor_base.py

@@ -153,6 +153,7 @@ def _setup_window(self) -> None:
             _("Amilcar Lucas's - ArduPilot methodic configurator ") + self.version + _(" - Vehicle Component Editor")
         )
         self.root.geometry(f"{WINDOW_WIDTH_PIX}x600")
+        BaseWindow.center_window_on_screen(self.root)
         self.root.protocol("WM_DELETE_WINDOW", self.on_closing)
 
     def _setup_styles(self) -> None:

ardupilot_methodic_configurator/frontend_tkinter_connection_selection.py

@@ -317,6 +317,7 @@ def __init__(
         super().__init__()
         self.root.title(_("AMC {version} - Flight controller connection").format(version=__version__))  # Set the window title
         self.root.geometry("520x462")  # Set the window size
+        BaseWindow.center_window_on_screen(self.root)
         self.default_baudrate = default_baudrate
 
         # Explain why we are here

ardupilot_methodic_configurator/frontend_tkinter_flightcontroller_info.py

@@ -76,6 +76,7 @@ def __init__(self, flight_controller: FlightController, vehicle_dir: Path) -> No
         super().__init__()
         self.root.title(_("AMC {version} - Flight Controller Info").format(version=__version__))  # Set the window title
         self.root.geometry("500x420")  # Adjust the window size as needed
+        BaseWindow.center_window_on_screen(self.root)
 
         self.presenter = FlightControllerInfoPresenter(flight_controller, vehicle_dir)
 

ardupilot_methodic_configurator/frontend_tkinter_parameter_editor.py

@@ -254,6 +254,7 @@ def __init__(
             _("Amilcar Lucas's - ArduPilot methodic configurator ") + __version__ + _(" - Parameter file editor and uploader")
         )
         self.root.geometry("990x630")  # Set the window width and height
+        BaseWindow.center_window_on_screen(self.root)
 
         # Bind the close_connection_and_quit function to the window close event
         self.root.protocol("WM_DELETE_WINDOW", self.close_connection_and_quit)

ardupilot_methodic_configurator/frontend_tkinter_progress_window.py

@@ -62,19 +62,27 @@ def __init__(  # pylint: disable=too-many-arguments, too-many-positional-argumen
         if not self.only_show_when_update_progress_called:
             self.progress_window.deiconify()  # needs to be done before centering, but it does flicker :(
 
-        # Center the progress window on screen or on parent
-        # Use screen centering if parent is a minimal temp root (like in FlightControllerConnectionProgress)
-        if isinstance(self.parent, tk.Tk) and self.parent.winfo_width() <= 1:
-            BaseWindow.center_window_on_screen(self.progress_window)
-        else:
-            BaseWindow.center_window(self.progress_window, self.parent)
+        self._center_progress_window()
 
         if not self.only_show_when_update_progress_called:
             # Show the window now that it's properly positioned
             self.progress_window.lift()
             self._shown = True
             self.progress_bar.update()
 
+    def _center_progress_window(self) -> None:
+        """
+        Center the progress window on screen or relative to its parent.
+
+        Uses screen centering when the parent is not viewable (e.g., a withdrawn temp root
+        in FlightControllerConnectionProgress). On Windows, withdrawn windows can report
+        winfo_width() > 1, so winfo_viewable() is checked as well.
+        """
+        if isinstance(self.parent, tk.Tk) and (self.parent.winfo_width() <= 1 or not self.parent.winfo_viewable()):
+            BaseWindow.center_window_on_screen(self.progress_window)
+        else:
+            BaseWindow.center_window(self.progress_window, self.parent)
+
     def update_progress_bar_300_pct(self, percent: int) -> None:
         self.message = _("Please be patient, {:.1f}% of {}% complete")
         self.update_progress_bar(int(percent / 3), max_value=100)
@@ -99,12 +107,7 @@ def update_progress_bar(self, current_value: int, max_value: int) -> None:
 
             if self.only_show_when_update_progress_called and not self._shown:
                 self.progress_window.deiconify()
-                # Re-center the window when it's first shown
-                # Use screen centering if parent is a minimal temp root
-                if isinstance(self.parent, tk.Tk) and self.parent.winfo_width() <= 1:
-                    BaseWindow.center_window_on_screen(self.progress_window)
-                else:
-                    BaseWindow.center_window(self.progress_window, self.parent)
+                self._center_progress_window()
                 self.progress_window.lift()
                 self._shown = True
             elif not self.only_show_when_update_progress_called:

ardupilot_methodic_configurator/frontend_tkinter_project_creator.py

@@ -136,6 +136,7 @@ def template_selection_callback(_widget: "DirectorySelectionWidgets") -> str:
         # Set dynamic window size based on number of settings
         window_height = 250 + (len(settings_metadata) * 23)
         self.root.geometry(f"800x{window_height}")  # Set the window size
+        BaseWindow.center_window_on_screen(self.root)
 
         for setting_name, metadata in settings_metadata.items():
             checkbox = ttk.Checkbutton(

ardupilot_methodic_configurator/frontend_tkinter_project_opener.py

@@ -56,6 +56,7 @@ def __init__(self, project_manager: VehicleProjectManager) -> None:
         )
 
         self.root.geometry("600x450")  # Set the window size
+        BaseWindow.center_window_on_screen(self.root)
 
         # Explain why we are here
         introduction_text = self.project_manager.get_introduction_message()

ardupilot_methodic_configurator/frontend_tkinter_software_update.py

@@ -28,6 +28,7 @@ def __init__(self, version_info: str, download_callback: Optional[Callable[[], b
             )
         )
         self.root.geometry("700x600")
+        BaseWindow.center_window_on_screen(self.root)
         self.download_callback = download_callback
         self.root.protocol("WM_DELETE_WINDOW", self.on_cancel)
 

ardupilot_methodic_configurator/frontend_tkinter_template_overview.py

@@ -116,6 +116,7 @@ def _configure_window(self) -> None:
         scaled_width = int(1200 * self.dpi_scaling_factor)
         scaled_height = int(600 * self.dpi_scaling_factor)
         self.root.geometry(f"{scaled_width}x{scaled_height}")
+        BaseWindow.center_window_on_screen(self.root)
 
     def _initialize_ui_components(self) -> None:
         """Initialize UI components with proper scaling."""