fix(window size): On KDE linux systems#1011
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes window sizing issues on Linux window managers (particularly KDE) that modify font sizes and padding. The changes implement dynamic window height calculation to ensure all widgets remain fully visible.
- Removed hardcoded window geometry to allow dynamic sizing based on content
- Added dynamic height calculation after widget placement using
winfo_reqheight() - Fixed a potential issue with the usage popup window callback by wrapping it in a lambda and adding existence check
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend_tkinter_usage_popup_window.py | Added dynamic height resizing logic to popup windows to accommodate varying font sizes and padding |
| frontend_tkinter_parameter_editor.py | Removed hardcoded window height, added dynamic height calculation, reordered startup notification, and fixed usage popup callback |
|
|
||
| # Set up startup notification for the main application window | ||
| FreeDesktop.setup_startup_notification(self.root) # type: ignore[arg-type] | ||
| if isinstance(self.root, tk.Tk) and UsagePopupWindow.should_display("parameter_editor"): |
There was a problem hiding this comment.
The isinstance(self.root, tk.Tk) check is unnecessary. According to the BaseWindow class definition, self.root is typed as Union[tk.Toplevel, tk.Tk], but ParameterEditorWindow inherits from BaseWindow and creates the main application window (no parent passed to __init__), so self.root will always be tk.Tk. This check adds unnecessary complexity.
| if isinstance(self.root, tk.Tk) and UsagePopupWindow.should_display("parameter_editor"): | |
| if UsagePopupWindow.should_display("parameter_editor"): |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Test Results 3 files 3 suites 2m 55s ⏱️ Results for commit 06952e9. ♻️ This comment has been updated with latest results. |
7094e89 to
47f4b12
Compare
47f4b12 to
06952e9
Compare
|
@neo-0007 please re-try it again |
|
@amilcarlucas It works fine now , Thanks ! |

Fixes #1010
@neo-0007 can you please test this fix on your linux KDE system?