-
Notifications
You must be signed in to change notification settings - Fork 63
Fix 3.14 tk tests #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 3.14 tk tests #1059
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -53,7 +53,12 @@ jobs: | |||||
| - name: Install system dependencies for GUI testing | ||||||
| run: | | ||||||
| sudo apt-get update | ||||||
| sudo apt-get install -y python3-tk scrot xdotool x11-utils gnome-screenshot | ||||||
| sudo apt-get install -y python3-tk scrot xdotool x11-utils gnome-screenshot tcl8.6 tk8.6 libtcl8.6 libtk8.6 | ||||||
|
|
||||||
| - name: Ensure Tcl/Tk search paths | ||||||
| run: | | ||||||
| echo "TCL_LIBRARY=/usr/share/tcltk/tcl8.6" >> $GITHUB_ENV | ||||||
| echo "TK_LIBRARY=/usr/share/tcltk/tk8.6" >> $GITHUB_ENV | ||||||
|
|
||||||
| - name: Install dependencies and application | ||||||
| # without --editable, the coverage report is not generated correctly | ||||||
|
|
@@ -222,7 +227,7 @@ jobs: | |||||
| echo "Pytest failed - failing coverage check" | ||||||
| exit 1 | ||||||
| fi | ||||||
| coverage report --fail-under=80 | ||||||
| coverage report --fail-under=89 | ||||||
|
|
||||||
| publish-test-results: | ||||||
| if: always() | ||||||
|
|
@@ -313,4 +318,4 @@ jobs: | |||||
| with: | ||||||
| coverageFile: coverage.xml | ||||||
| token: ${{ secrets.GITHUB_TOKEN }} | ||||||
| thresholdAll: 0.80 | ||||||
| thresholdAll: 0.89 | ||||||
|
||||||
| thresholdAll: 0.89 | |
| thresholdAll: 0.80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage threshold has been increased from 80% to 89%, which is a significant jump of 9 percentage points. This appears to be an arbitrary change that is not directly related to fixing Python 3.14 Tcl/Tk tests. According to ARCHITECTURE.md, coverage should "increase monotonically", but such a large jump may cause issues if the actual coverage improvement is smaller. Consider verifying that the actual coverage increase justifies this threshold change, or adjust it to match the actual coverage achieved by the test improvements.