Skip to content

fix macOS tests#1284

Closed
OmkarSarkar204 wants to merge 1 commit into
ArduPilot:masterfrom
OmkarSarkar204:macOS_tests
Closed

fix macOS tests#1284
OmkarSarkar204 wants to merge 1 commit into
ArduPilot:masterfrom
OmkarSarkar204:macOS_tests

Conversation

@OmkarSarkar204

Copy link
Copy Markdown
Contributor

Mac Tests for PR #1066

Comment thread tests/test_frontend_tkinter_rich_text.py Outdated
Comment thread .github/workflows/pytest.yml Outdated
Comment thread .github/workflows/pytest.yml Outdated
Comment thread .github/workflows/pytest.yml Outdated
Comment thread .github/workflows/pytest.yml
@OmkarSarkar204 OmkarSarkar204 force-pushed the macOS_tests branch 2 times, most recently from e6b50d6 to 7f06dbd Compare February 11, 2026 12:55
@OmkarSarkar204 OmkarSarkar204 changed the base branch from macOS_tests to master February 11, 2026 12:58

@amilcarlucas amilcarlucas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest commits removed a lot of comments. Please put them back in.
This is very easy to do using either "git gui" or git extensions.
You can revert changes line by line.

@OmkarSarkar204

Copy link
Copy Markdown
Contributor Author

The latest commits removed a lot of comments. Please put them back in. This is very easy to do using either "git gui" or git extensions. You can revert changes line by line.

yes sorry im working on it.

@amilcarlucas

Copy link
Copy Markdown
Collaborator

And you "lost" the python code fixes

@OmkarSarkar204

Copy link
Copy Markdown
Contributor Author

Hello @amilcarlucas, I added the test fixes all are passing locally now I definitely messed up my git workflow today and i apologize for it, guess i have to learn a lot about git. Thank you for your patience.

@OmkarSarkar204

Copy link
Copy Markdown
Contributor Author

The Tests are passing locally but the CI CD is failing it every time , im still trying some more fixes.

@amilcarlucas

Copy link
Copy Markdown
Collaborator

No problem, git can be tricky sometimes.
Please use "git rebase -i" to rebase your changes on top of mine, or on top of master.

It takes a while to master git rebase, but it is worth it.

@amilcarlucas

Copy link
Copy Markdown
Collaborator

I cherry-picked some of the "safe" changes into #1285

@OmkarSarkar204

Copy link
Copy Markdown
Contributor Author

No problem, git can be tricky sometimes. Please use "git rebase -i" to rebase your changes on top of mine, or on top of master.

It takes a while to master git rebase, but it is worth it.

Thank you so much. I used git rebase -i and pushed the changes, please tell me if you need anything else

@amilcarlucas

Copy link
Copy Markdown
Collaborator

Can you rebase it on Master? If not, I'll do it tomorrow

Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
@amilcarlucas

Copy link
Copy Markdown
Collaborator

#1288 contains a part of your fixes, and activates CI tests using MS windows.
I hope the windows fixes I did there will help you in your macOS fixes.

@amilcarlucas

Copy link
Copy Markdown
Collaborator

Replaced by #1297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants