Skip to content

Include the 39_autotune_roll_pitch_retune_results.param file #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amilcarlucas merged 1 commit into from
Mar 23, 2026
Merged

Include the 39_autotune_roll_pitch_retune_results.param file #1424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ardupilot_methodic_configurator/data_model_parameter_editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@ def _update_tuning_report(self) -> None:
"33_autotune_pitch_results.param",
"35_autotune_yaw_results.param",
"37_autotune_yawd_results.param",
"39_autotune_roll_pitch_results.param",
"39_autotune_roll_pitch_retune_results.param",
]
Comment on lines 952 to 956
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title says “Include the 39_autotune_roll_pitch_retune_results.param file”, but the change replaces "39_autotune_roll_pitch_results.param" rather than adding the new file alongside it. If the intent is to support both outputs (existing results + retune results), keep "39_autotune_roll_pitch_results.param" in the list and add "39_autotune_roll_pitch_retune_results.param" as an additional entry; only replace it if the old filename is truly obsolete and should no longer be considered.

Copilot uses AI. Check for mistakes.

report_file_path = Path(getattr(self._local_filesystem, "vehicle_dir", ".")) / "tuning_report.csv"
Expand Down
Loading