Esc followup by amilcarlucas · Pull Request #1510 · ArduPilot/MethodicConfigurator

amilcarlucas · 2026-04-15T20:25:42Z

Description

This updates the templates with ESC->FC Telemetry information

Checklist

Run pre-commit checks locally
Verified by a human programmer
All commits are signed off (use git commit --signoff)
Code follows our coding standards
Documentation updated if needed
No breaking changes or properly documented

Testing

Describe how you tested these changes:

Unit tests pass
Integration tests pass
Manual testing performed
Tested on flight controller hardware

Needed per-cell voltage to estimate cells, needed cells to compute per-cell voltage by using chemistry-default voltages instead of the model's current values.

Copilot

Pull request overview

Updates vehicle templates (and supporting import/i18n code) to better represent ESC-to-flight-controller telemetry wiring/configuration, plus related template parameter adjustments.

Changes:

Add explicit ESC connection sections in templates: FC->ESC Connection and ESC->FC Telemetry.
Adjust multiple template .param files for battery thresholds, GNSS/CAN settings, and telemetry port settings to match updated component definitions.
Update component import logic for battery cell-count estimation using chemistry-based recommended per-cell voltages; extend translatable component descriptions.

Reviewed changes

Copilot reviewed 59 out of 59 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
ardupilot_methodic_configurator/vehicle_templates/Rover/Carisma_SCA-1E/vehicle_components.json	Adds ESC telemetry section; updates battery thresholds and port mappings.
ardupilot_methodic_configurator/vehicle_templates/Rover/Carisma_SCA-1E/13_general_configuration.param	Moves/extends serial settings and SR1 stream rate parameters.
ardupilot_methodic_configurator/vehicle_templates/Rover/Carisma_SCA-1E/12_mp_setup_mandatory_hardware.param	Updates motor battery voltage min/max thresholds.
ardupilot_methodic_configurator/vehicle_templates/Rover/Carisma_SCA-1E/10_gnss.param	Switches GNSS configuration toward CAN/GPS1_* params.
ardupilot_methodic_configurator/vehicle_templates/Rover/Carisma_SCA-1E/09_batt2.param	Removes prior BATT2 parameter step content.
ardupilot_methodic_configurator/vehicle_templates/Rover/Carisma_SCA-1E/08_batt1.param	Updates primary battery failsafe voltages and consolidates BATT2 settings.
ardupilot_methodic_configurator/vehicle_templates/Rover/Carisma_SCA-1E/06_telemetry.param	Updates telemetry to SERIAL4 and removes SERIAL1 stream settings.
ardupilot_methodic_configurator/vehicle_templates/Rover/AION_R1/vehicle_components.json	Adds ESC telemetry section; adjusts battery monitor connection and battery mins.
ardupilot_methodic_configurator/vehicle_templates/Rover/AION_R1/10_gnss.param	Adds CAN protocol enable; keeps GNSS settings.
ardupilot_methodic_configurator/vehicle_templates/Rover/AION_R1/08_batt1.param	Comment wording adjustments for battery voltage thresholds.
ardupilot_methodic_configurator/vehicle_templates/Heli/OMP_M4/vehicle_components.json	Adds ESC telemetry section; reorganizes RC/telemetry blocks; updates program version.
ardupilot_methodic_configurator/vehicle_templates/ArduPlane/normal_plane/vehicle_components.json	Adds ESC telemetry section.
ardupilot_methodic_configurator/vehicle_templates/ArduPlane/normal_plane/10_gnss.param	Sets SERIAL3_PROTOCOL to GPS (5).
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/empty_4.6.x/vehicle_components.json	Adds ESC telemetry section; modifies default battery per-cell voltage specs.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/empty_4.6.x/53_everyday_use.param	Removes BATT2 low failsafe action parameter.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/empty_4.6.x/08_batt1.param	Zeros battery voltage thresholds for “empty” template.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/empty_4.5.x/vehicle_components.json	Adds ESC telemetry section; modifies battery per-cell voltage specs; tweaks disabled protocol labeling.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/empty_4.5.x/53_everyday_use.param	Removes BATT2 low failsafe action parameter.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/empty_4.5.x/08_batt1.param	Zeros battery voltage thresholds; adds comment for BATT_MONITOR.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.6.x-params/vehicle_components.json	Adds ESC telemetry section; updates battery min per-cell.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.6.x-params/08_batt1.param	Adjusts MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.5.x-params/vehicle_components.json	Adds ESC telemetry section; updates battery min per-cell.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.5.x-params/08_batt1.param	Adjusts MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.4.4-params/vehicle_components.json	Adds ESC telemetry section; updates battery min per-cell.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.4.4-params/08_batt1.param	Adjusts MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.3.8-params/vehicle_components.json	Adds ESC telemetry section; updates battery min per-cell.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.3.8-params/08_batt1.param	Adjusts MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/X11_plus/vehicle_components.json	Adds ESC telemetry section; updates battery chemistry/max/min per-cell.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/X11_plus/08_batt1.param	Updates MOT_BAT_VOLT_MIN/MAX scaling thresholds.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Tarot_X4/vehicle_components.json	Adds ESC telemetry section; updates telemetry port mapping.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/TarotFY680Hexacopter/vehicle_components.json	Adds ESC telemetry section with SERIAL7 ESC Telemetry.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/ReadyToSkyZD550/vehicle_components.json	Adds ESC telemetry section; updates telemetry protocol label.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/ReadyToSkyZD550/08_batt1.param	Updates MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Marmotte5v2/vehicle_components.json	Adds ESC telemetry section; sets telemetry to BDShot on Main Out.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Marmotte5v2/08_batt1.param	Updates MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Hoverit_X13/vehicle_components.json	Adds ESC telemetry section; updates battery min per-cell.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Hoverit_X13/08_batt1.param	Updates MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Hoverit_X11+/vehicle_components.json	Adds ESC telemetry section; updates battery min per-cell.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Hoverit_X11+/10_gnss.param	Adds CAN2 enable params; comment fixes.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Hoverit_X11+/08_batt1.param	Updates MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X650_LTE/vehicle_components.json	Adds ESC telemetry section (BDShot on Main Out).
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X650_LTE/06_telemetry.param	Adds SERIAL1_PROTOCOL=MAVLink2.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500_V2/vehicle_components.json	Adds ESC telemetry section.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500_V2/12_mp_setup_mandatory_hardware.param	Sets SERVO1-4_FUNCTION to motor outputs (33-36).
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/vehicle_components.json	Adds ESC telemetry section.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/GazeboIrisWithTargetFollow/vehicle_components.json	Adds ESC telemetry section; updates simulated battery chemistry/cell count.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/GazeboIrisWithTargetFollow/08_batt1.param	Updates battery thresholds for 3S simulated pack; updates MOT_BAT_VOLT scaling thresholds.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/FETtec-5/vehicle_components.json	Splits ESC connection vs telemetry (both SERIAL1 for one-wire ESC).
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/FETtec-5/08_batt1.param	Adjusts MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Demo32Motor_PeterHall/vehicle_components.json	Adds ESC telemetry section.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Demo32Motor_PeterHall/10_gnss.param	Adds CAN protocol enable param.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Chimera7/vehicle_components.json	Adds ESC telemetry section; updates battery min per-cell.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Chimera7/08_batt1.param	Updates MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Big_Owl/vehicle_components.json	Adds ESC telemetry section.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/AirCar_v1/vehicle_components.json	Adds ESC telemetry section; updates GNSS connection type to CAN; tweaks battery min per-cell.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/AirCar_v1/08_batt1.param	Updates MOT_BAT_VOLT_MIN threshold.
ardupilot_methodic_configurator/vehicle_components.py	Adds new translatable schema descriptions for ESC connections/telemetry.
ardupilot_methodic_configurator/data_model_vehicle_components_import.py	Uses chemistry defaults for estimating battery cell count; refactors estimation helper.

Copilot · 2026-04-15T20:32:18Z

+                "Volt per cell max": 0.0,
+                "Volt per cell arm": 0.0,
+                "Volt per cell low": 0.0,
+                "Volt per cell crit": 0.0,
+                "Volt per cell min": 0.0,


The battery per-cell voltage specs were changed to 0.0 while chemistry remains "Lipo". This violates the project’s battery voltage validation (0.0 is below the chemistry minimum) and will likely cause immediate validation errors/auto-corrections when the template is loaded. Prefer omitting these fields or setting them to sensible defaults for the chosen chemistry.

Copilot · 2026-04-15T20:32:19Z

 CAN_P1_DRIVER,1
 GPS_AUTO_SWITCH,2  # Randy I do not understand why this, there is only one GNSS receiver
-GPS_GNSS_MODE,0  # limit the constalations to ensure an update rate higher than 5Hz
+GPS_GNSS_MODE,0  # limit the constellations to ensure an update rate higher than 5Hz


Spelling in comment: "constalations" should be "constellations".

Copilot · 2026-04-15T20:32:19Z

+    _vehicle_components_descriptions = _("Data path from flight controller to ESC")
    _vehicle_components_descriptions = _("Details about how a component connects to the flight controller")
+    _vehicle_components_descriptions = _("ESC firmware information")
+    _vehicle_components_descriptions = _("Electronic Speed Controller component with (optional) telemetry")


vehicle_components.py is auto-generated to provide gettext extraction for strings used in vehicle_components.json. This PR introduces new JSON keys like "FC->ESC Connection" and "ESC->FC Telemetry" (and uses them in the UI/data model), but they are not present in translatable_strings(), so they won’t be extracted for translation. Re-run the generator (or update it) so these new key strings are included in translatable_strings().

Copilot · 2026-04-15T20:32:19Z

+                "Volt per cell max": 0.0,
+                "Volt per cell arm": 0.0,
+                "Volt per cell low": 0.0,
+                "Volt per cell crit": 0.0,
+                "Volt per cell min": 0.0,


The battery per-cell voltage specs were changed to 0.0 while chemistry remains "Lipo". This violates the project’s battery voltage validation (0.0 is below the chemistry minimum) and will likely cause immediate validation errors/auto-corrections when the template is loaded. Prefer omitting these fields or setting them to sensible defaults for the chosen chemistry.

…stency

…trings

github-actions · 2026-04-15T20:41:51Z

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
12124	11402	94%	89%	🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: d7ab5ac by action🐍

fix(vehicle components): break a circular dependency

415764c

Needed per-cell voltage to estimate cells, needed cells to compute per-cell voltage by using chemistry-default voltages instead of the model's current values.

Copilot AI review requested due to automatic review settings April 15, 2026 20:25

Copilot started reviewing on behalf of amilcarlucas April 15, 2026 20:26 View session

amilcarlucas force-pushed the ESC_followup branch from f091e5b to a6e0bff Compare April 15, 2026 20:31

Copilot AI reviewed Apr 15, 2026

View reviewed changes

amilcarlucas and others added 3 commits April 15, 2026 22:39

chore(vehicle templates): Added ESC-> FC Telemetry and improved consi…

139e296

…stency

docs(component_editor): Auto-update vehicle components translatable s…

a99c518

…trings

ci(translations): Improve the automated commit message

d7ab5ac

amilcarlucas force-pushed the ESC_followup branch from a6e0bff to d7ab5ac Compare April 15, 2026 20:48

amilcarlucas merged commit c0cd6f8 into master Apr 15, 2026
17 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Esc followup#1510

Esc followup#1510
amilcarlucas merged 4 commits into
masterfrom
ESC_followup

amilcarlucas commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

amilcarlucas commented Apr 15, 2026

Description

Checklist

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☂️ Python Coverage

Overall Coverage

New Files

Modified Files

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Apr 15, 2026 •

edited

Loading